-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug 1872802: remove old MCO etcd quorum guard resources #429
bug 1872802: remove old MCO etcd quorum guard resources #429
Conversation
/lgtm cc @cgwalters @kikisdeliveryservice we feel that my changes in mco#1933 exposed a failure case that is blocking CI promotion. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, hexfusion The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@deads2k: This pull request references Bugzilla bug 1872802, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@hexfusion |
this is just about to merge I am testing upgrade in clusterbot as well. I am going to raise a partial revert on #1933 in case. |
/refresh |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
bootstrap was a success MCD was happy[1], AWS test failures were related to Prometheus[2] |
@deads2k: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Clusterbot minor upgrade was a success. |
@deads2k: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Bugzilla bug 1872802 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This cleans up the old mco pdb after the new one is in place. It may fight with and old MCO operator, but only until that operator gets its new deployment.