-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API alerts after recent bump to k8s 1.25 #1382
Update API alerts after recent bump to k8s 1.25 #1382
Conversation
/lgtm |
fc6e153
to
ecac851
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
/retest-required |
/lgtm |
/test e2e-aws-serial |
/override ci/prow/e2e-aws-serial Lets move this forward, the serial test failures are unrelated to the operator and we can fix them next. |
/hold for @soltysh approval |
@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-aws-serial In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, sanchezl, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@soltysh: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The failures in this PR are not related with this particular change, they are failing on issues described in https://issues.redhat.com/browse/RCMAUTO-6093. Additionally this fixes API alerts which in the long run will ensure they are not firing unnecessarily. |
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-aws-ovn, ci/prow/e2e-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @sanchezl @mfojtik