Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API alerts after recent bump to k8s 1.25 #1382

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

soltysh
Copy link

@soltysh soltysh commented Oct 4, 2022

@mfojtik
Copy link
Contributor

mfojtik commented Oct 4, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot requested review from sttts and tkashem October 4, 2022 08:07
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 4, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 843db4f and 2 for PR HEAD fc6e153 in total

@soltysh soltysh force-pushed the bump_alert_version branch from fc6e153 to ecac851 Compare October 4, 2022 13:58
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2022
Copy link
Contributor

@sanchezl sanchezl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sanchezl
Copy link
Contributor

sanchezl commented Oct 4, 2022

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 843db4f and 2 for PR HEAD ecac851 in total

@sanchezl
Copy link
Contributor

sanchezl commented Oct 5, 2022

/retest-required

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2022
@mfojtik
Copy link
Contributor

mfojtik commented Oct 5, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 843db4f and 2 for PR HEAD 3d985c7 in total

@soltysh
Copy link
Author

soltysh commented Oct 6, 2022

/test e2e-aws-serial

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9c36fe3 and 1 for PR HEAD 3d985c7 in total

@mfojtik
Copy link
Contributor

mfojtik commented Oct 7, 2022

/override ci/prow/e2e-aws-serial
/approve

Lets move this forward, the serial test failures are unrelated to the operator and we can fix them next.

@mfojtik
Copy link
Contributor

mfojtik commented Oct 7, 2022

/hold

for @soltysh approval

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 7, 2022

@mfojtik: Overrode contexts on behalf of mfojtik: ci/prow/e2e-aws-serial

In response to this:

/override ci/prow/e2e-aws-serial
/approve

Lets move this forward, the serial test failures are unrelated to the operator and we can fix them next.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, sanchezl, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Author

soltysh commented Oct 7, 2022

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 7, 2022

@soltysh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-single-node 3d985c7 link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-operator-disruptive-single-node 3d985c7 link false /test e2e-aws-operator-disruptive-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh
Copy link
Author

soltysh commented Oct 7, 2022

The failures in this PR are not related with this particular change, they are failing on issues described in https://issues.redhat.com/browse/RCMAUTO-6093. Additionally this fixes API alerts which in the long run will ensure they are not firing unnecessarily.
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 7, 2022

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/e2e-aws-ovn, ci/prow/e2e-upgrade

In response to this:

The failures in this PR are not related with this particular change, they are failing on issues described in https://issues.redhat.com/browse/RCMAUTO-6093. Additionally this fixes API alerts which in the long run will ensure they are not firing unnecessarily.
/override ci/prow/e2e-aws-ovn
/override ci/prow/e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants