Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MON-4129: adjust Prometheus classic histograms 'le' related selectors in rules defs and relabel config to accommodate the update to Prometheus v3 #1784

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

machine424
Copy link

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 15, 2025
Copy link
Contributor

openshift-ci bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: machine424
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2554
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-rosa-sts-hypershift-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/50647e70-d3fb-11ef-84ae-020c1e634813-0

Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2554
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-rosa-sts-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6c58b6a0-d3fb-11ef-9ad3-ed24ac0f8204-0

Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2554
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-rosa-sts-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/88b2b380-d411-11ef-93dc-3c642b2d31ff-0

@machine424
Copy link
Author

machine424 commented Jan 17, 2025

/retitle MON-4129: adjust Prometheus histograms 'le' related selectors in rules relabel config

@openshift-ci openshift-ci bot changed the title WIP: adjust histograms 'le' related selectors MON-4129: adjust Prometheus histograms 'le' related selectors in rules relabel config Jan 17, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2025

@machine424: This pull request references MON-4129 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2025
@machine424 machine424 changed the title MON-4129: adjust Prometheus histograms 'le' related selectors in rules relabel config WIP: MON-4129: adjust Prometheus histograms 'le' related selectors in rules relabel config Jan 17, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2025
@machine424
Copy link
Author

/retest

@machine424
Copy link
Author

machine424 commented Jan 30, 2025

/retitle MON-4129: adjust Prometheus classic histograms 'le' related selectors in rules defs and relabel config to accommodate the update to Prometheus v3

@openshift-ci openshift-ci bot changed the title WIP: MON-4129: adjust Prometheus histograms 'le' related selectors in rules relabel config MON-4129: adjust Prometheus classic histograms 'le' related selectors in rules defs and relabel config to accommodate the update to Prometheus v3 Jan 30, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2025
Copy link
Contributor

openshift-ci bot commented Jan 30, 2025

@machine424: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-operator-single-node d030fb5 link false /test e2e-gcp-operator-single-node
ci/prow/e2e-aws-operator-disruptive-single-node d030fb5 link false /test e2e-aws-operator-disruptive-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants