Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-4865: replace loki.labels with remap transformation #2374

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

vparfonov
Copy link
Contributor

@vparfonov vparfonov commented Feb 24, 2024

Description

This PR adding remap transformation to be ensured that all labels are present, to avoid error in loki.labels step.
https://vector.dev/docs/reference/configuration/sinks/loki/#labels. At the moment labels section doesn't support fallback feature.
There is opened issue for this but not resolved yet: vectordotdev/vector#1692

/cc
/assign

/cherry-pick

Links

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 24, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 24, 2024

@vparfonov: This pull request references LOG-4865 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

Description

/cc
/assign

/cherry-pick

Links

  • Depending on PR(s):
  • Bugzilla:
  • Github issue:
  • JIRA:
  • Enhancement proposal:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2024
Copy link
Contributor

openshift-ci bot commented Feb 24, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vparfonov
Copy link
Contributor Author

/test all

@vparfonov
Copy link
Contributor Author

/test all

@vparfonov vparfonov marked this pull request as ready for review February 26, 2024 11:36
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2024
@openshift-ci openshift-ci bot requested review from cahartma and jcantrill February 26, 2024 11:36
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 26, 2024

@vparfonov: This pull request references LOG-4865 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.8.0" version, but no target version was set.

In response to this:

Description

This PR adding remap transformation to be ensured that all labels are present, to avoid error in loki.labels step.
https://vector.dev/docs/reference/configuration/sinks/loki/#labels. At the moment labels section doesn't support fallback feature.
There is opened issue for this but not resolved yet: vectordotdev/vector#1692

/cc
/assign

/cherry-pick

Links

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vparfonov
Copy link
Contributor Author

/assign @jcantrill
/cc @cahartma @Clee2691

Copy link
Contributor

openshift-ci bot commented Feb 26, 2024

@vparfonov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-target-minus-one 4f51c6e link false /test e2e-ocp-target-minus-one

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcantrill
Copy link
Contributor

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2024
@jcantrill
Copy link
Contributor

/hold cancel
/approve
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 26, 2024
Copy link
Contributor

openshift-ci bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, vparfonov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3f27d41 into openshift:master Feb 26, 2024
9 of 10 checks passed
@vparfonov vparfonov deleted the log4865 branch February 27, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. release/5.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants