Skip to content

Commit

Permalink
let's try increasing shm-size
Browse files Browse the repository at this point in the history
  • Loading branch information
alecmerdler committed Oct 5, 2018
1 parent d81ea6f commit e8cf603
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 2 deletions.
1 change: 1 addition & 0 deletions builder-run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,6 @@ docker run $ENV_STR --rm --net=host \
--user="${BUILDER_RUN_USER}" \
$VOLUME_MOUNT \
-v "$(pwd)":/go/src/github.com/openshift/console \
--shm-size=256m
-w /go/src/github.com/openshift/console \
$BUILDER_IMAGE "$@"
2 changes: 1 addition & 1 deletion frontend/integration-tests/protractor.conf.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export const config: Config = {
'--window-size=1920,1200',
'--disable-background-timer-throttling',
'--disable-renderer-backgrounding',
'--disable-raf-throttling'
'--disable-raf-throttling',
],
prefs: {
'profile.password_manager_enabled': false,
Expand Down
3 changes: 3 additions & 0 deletions frontend/public/components/source-to-image.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ class BuildSource extends React.Component<BuildSourceProps, BuildSourceState> {
}

static getDerivedStateFromProps(props, state) {
if (_.isEmpty(props.obj.data)) {
return null;
}
const previousTag = state.selectedTag;
// Sort tags in reverse order by semver, falling back to a string comparison if not a valid version.
const tags = getBuilderTagsSortedByVersion(props.obj.data);
Expand Down
2 changes: 1 addition & 1 deletion frontend/public/components/utils/firehose.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ export const Firehose = connect(
]));

// FIXME(alecmerdler): Many bugs surfacing from rendering children with no data...
return this.props.loaded
return this.props.loaded || this.firehoses.length > 0
? <ConnectToState reduxes={reduxes}> {children} </ConnectToState>
: null;
}
Expand Down

0 comments on commit e8cf603

Please sign in to comment.