OCPBUGS-6634: Enable building tectonic-console-builder on arm64 and fix the Dockerfile.product to work with no cached artifacts

[aleskandro]

This PR will allow:

1. building the console-tecotonic-builder (Dockerfile.builder) and the console (Dockerfile) on architectures different than amd64;
2. building the console using the Dockerfile.product outside the internal build engines.

I disabled the installation of google-chrome in the Dockerfile.builder as it is not shipped for arm64: chromium is available, but I'm not sure it is ok for the purpose it has in the tests.

Still, console-tectonic-builder will only allow building the console on arm64 once nodeJs is bumped to v14.17.0 (see nodejs/help#3202). As the idea is to switch using a unique Dockerfile for both the CI and the shipped product, this PR will not address the version bump, and the builds for arm64 can work from the Dockerfile.product.

After this is merged, openshift/release#35527 can land, and we can start using Dockerfile.product in the CI and for OKD.

The changes to the Dockerfile.product have been tested in prow through a temporary commit. log here.

cc @jeffdyoung @LorbusChris

[jhadvig]

Thanks for the change @aleskandro 👍 Please let me know once you change the image in the .ci-operator.yaml file

[aleskandro]

Based on the discussion in https://redhat-internal.slack.com/archives/C6A3NV5J9/p1674051149090609, I'm giving a shot to make the Dockerfile.product compatible for both ART and Prow builds.

[aleskandro]

The changes to the Dockerfile.product have been tested in prow through a temporary commit. log here.

They will also be ok to build on arm64 as already done by ART.

Though, I would also check-in the ones in the Dockerfile.builder to make it general enough to work on other architectures

/cc @spadgett

[aleskandro]

Can the test suite use chromium and provide reliable test results? We could install it at least for non-amd64 images.

[spadgett]

Thanks @aleskandro. I think it would be good to have ART review the Dockerfile.product changes.

/cc @sosiouxme

[aleskandro]

/unhold

[LorbusChris]

@aleskandro if Dockerfile is going to go away, why not replace it with a symlink to Dockerfile.product here in this PR?

[aleskandro]

@aleskandro if Dockerfile is going to go away, why not replace it with a symlink to Dockerfile.product here in this PR?

We could also rename Dockerfile.product to Dockerfile then and change the ref in https://github.com/openshift/ocp-build-data/blob/openshift-4.13/images/openshift-enterprise-console.yml#L3. Can't we?

[LorbusChris]

Sure, it's just when the two are symlinks the config changes in release and ocp-build-data become optional/merely cleanup.

[LorbusChris]

/lgtm

[aleskandro]

/assign @jhadvig

[spadgett]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleskandro, LorbusChris, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aleskandro]

The failing tests seem unrelated, can we skip?

[openshift-ci-robot]

@aleskandro: This pull request references Jira Issue OCPBUGS-6634, which is invalid:

• expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR will allow:

1. building the console-tecotonic-builder (Dockerfile.builder) and the console (Dockerfile) on architectures different than amd64;
2. building the console using the Dockerfile.product outside the internal build engines.

I disabled the installation of google-chrome in the Dockerfile.builder as it is not shipped for arm64: chromium is available, but I'm not sure it is ok for the purpose it has in the tests.

Still, console-tectonic-builder will only allow building the console on arm64 once nodeJs is bumped to v14.17.0 (see nodejs/help#3202). As the idea is to switch using a unique Dockerfile for both the CI and the shipped product, this PR will not address the version bump, and the builds for arm64 can work from the Dockerfile.product.

After this is merged, openshift/release#35527 can land, and we can start using Dockerfile.product in the CI and for OKD.

The changes to the Dockerfile.product have been tested in prow through a temporary commit. log here.

cc @jeffdyoung @LorbusChris

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aleskandro]

/jira refresh

[openshift-ci-robot]

@aleskandro: This pull request references Jira Issue OCPBUGS-6634, which is invalid:

• expected the bug to target the "4.13.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aleskandro]

/jira refresh

[openshift-ci-robot]

@aleskandro: This pull request references Jira Issue OCPBUGS-6634, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.13.0) matches configured target version for branch (4.13.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 8208836 and 2 for PR HEAD d9649c2 in total

[jhadvig]

/test e2e-gcp-console

[jhadvig]

1) Testing uninstall of Business Automation Operator
       "before each" hook for "attempts to uninstall the Operator and delete all Operand Instances, shows 'Error Deleting Operands' alert":
     CypressError: Timed out retrying after 30050ms: `cy.click()` failed because this element:
`<a data-test="nav" class="pf-c-nav__link pf-m-current" href="/k8s/ns/test-omyaf/operators.coreos.com~v1alpha1~ClusterServiceVersion" aria-current="page">Install...</a>`
is being covered by another element:
`<div class="ReactModal__Overlay ReactModal__Overlay--after-open co-overlay">...</div>`

[jhadvig]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD bc95861 and 1 for PR HEAD d9649c2 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD c563862 and 0 for PR HEAD d9649c2 in total

[openshift-ci-robot]

@aleskandro: All pull requests linked via external trackers have merged:

• openshift/console#12444

Jira Issue OCPBUGS-6634 has been moved to the MODIFIED state.

In response to this:

This PR will allow:

1. building the console-tecotonic-builder (Dockerfile.builder) and the console (Dockerfile) on architectures different than amd64;
2. building the console using the Dockerfile.product outside the internal build engines.

I disabled the installation of google-chrome in the Dockerfile.builder as it is not shipped for arm64: chromium is available, but I'm not sure it is ok for the purpose it has in the tests.

Still, console-tectonic-builder will only allow building the console on arm64 once nodeJs is bumped to v14.17.0 (see nodejs/help#3202). As the idea is to switch using a unique Dockerfile for both the CI and the shipped product, this PR will not address the version bump, and the builds for arm64 can work from the Dockerfile.product.

After this is merged, openshift/release#35527 can land, and we can start using Dockerfile.product in the CI and for OKD.

The changes to the Dockerfile.product have been tested in prow through a temporary commit. log here.

cc @jeffdyoung @LorbusChris

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.