-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws: Add an experimental IPv6 dev/test environment #2555
Changes from all commits
1777816
eb557b0
e770d2e
0f719ef
5b44046
6d19648
e8ea7af
9a7fa84
68636ab
4a64b3d
b1c9acf
2a1ac77
d1f795d
750c4b2
3874adc
c46de1a
b0add46
834b8b3
8521d1d
118af89
86c9307
9648a03
3e06624
76f1ab0
2eb483e
40891fb
7d7082f
9907dd2
c21d6df
df9156f
9b4f14d
71acc53
95064cf
b235ba1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,3 +2,6 @@ output "ip_addresses" { | |
value = aws_network_interface.master.*.private_ips | ||
} | ||
|
||
output "ipv6_addresses" { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also similar question to #2555 (comment) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one seems like a toss-up. The master module does not take a |
||
value = data.aws_network_interface.master.*.ipv6_addresses | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -153,4 +153,3 @@ resource "aws_lb_listener" "api_external_api" { | |
type = "forward" | ||
} | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,10 @@ output "vpc_cidrs" { | |
value = [data.aws_vpc.cluster_vpc.cidr_block] | ||
} | ||
|
||
output "vpc_ipv6_cidrs" { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why not use There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because the VPC has both IPv4 and IPv6 CIDRs There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. my question was does the output need to make the distinct? can they be a single list? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It wouldn't be easy to just use a single list. They are used as input to different options on a resource: |
||
value = [data.aws_vpc.cluster_vpc.ipv6_cidr_block] | ||
} | ||
|
||
output "az_to_private_subnet_id" { | ||
value = zipmap(data.aws_subnet.private.*.availability_zone, data.aws_subnet.private.*.id) | ||
} | ||
|
@@ -63,4 +67,3 @@ output "aws_lb_api_internal_dns_name" { | |
output "aws_lb_api_internal_zone_id" { | ||
value = aws_lb.api_internal.zone_id | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we open an issue with upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I had moved on once I had an easy enough workaround. I can come back around to filing an upstream issue with a reproducer later, though.