Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix base files and regenerate bundle-ocp and dockerfile #384

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cpmeadors
Copy link
Contributor

@cpmeadors cpmeadors commented Jan 16, 2025

this catches up the generated bundle for ocp with the code.
Include version bumps for cert-manager deployment scripts

@openshift-ci openshift-ci bot requested review from kannon92 and mamy-CS January 16, 2025 20:54
Copy link

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpmeadors

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 16, 2025
@cpmeadors
Copy link
Contributor Author

/ok-to-test

@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 16, 2025
@cpmeadors
Copy link
Contributor Author

/retest

@harche
Copy link
Contributor

harche commented Jan 17, 2025

Unfortunately still fails with same error,

 Warning  FailedCreate  68s (x15 over 2m30s)  daemonset-controller  Error creating: pods "instaslice-operator-controller-daemonset-" is forbidden: unable to validate against any security context constraint: [provider "anyuid": Forbidden: not usable by user or serviceaccount, provider restricted-v2: .containers[0].privileged: Invalid value: true: Privileged containers are not allowed, provider restricted-v2: .containers[0].capabilities.add: Invalid value: "ALL": capability may not be added, provider restricted-v2: .containers[0].allowPrivilegeEscalation: Invalid value: true: Allowing privilege escalation for containers is not allowed, provider "restricted": Forbidden: not usable by user or serviceaccount, provider "nonroot-v2": Forbidden: not usable by user or serviceaccount, provider "nonroot": Forbidden: not usable by user or serviceaccount, provider "hostmount-anyuid": Forbidden: not usable by user or serviceaccount, provider "machine-api-termination-handler": Forbidden: not usable by user or serviceaccount, provider "hostnetwork-v2": Forbidden: not usable by user or serviceaccount, provider "hostnetwork": Forbidden: not usable by user or serviceaccount, provider "hostaccess": Forbidden: not usable by user or serviceaccount, provider "node-exporter": Forbidden: not usable by user or serviceaccount, provider "privileged": Forbidden: not usable by user or serviceaccount]

@harche
Copy link
Contributor

harche commented Jan 17, 2025

Also, the openshift cert manager operator didn't get installed as well,

harshal@fedora:~/go/src/github.com/openshift/instaslice-operator$ oc get pods -n cert-manager 
No resources found in cert-manager namespace.
harshal@fedora:~/go/src/github.com/openshift/instaslice-operator$ oc get pods -n cert-manager-operator 
No resources found in cert-manager-operator namespace.
harshal@fedora:~/go/src/github.com/openshift/instaslice-operator$ 

for the record I invoked the tests by,

harshal@fedora:~/go/src/github.com/openshift/instaslice-operator$ export IMG=quay.io/harpatil/instaslice2-controller:1.1
harshal@fedora:~/go/src/github.com/openshift/instaslice-operator$ export IMG_DMST=quay.io/harpatil/instaslice2-daemonset:1.1
harshal@fedora:~/go/src/github.com/openshift/instaslice-operator$ export BUNDLE_IMG=quay.io/harpatil/instaslice-bundle:1.1
harshal@fedora:~/go/src/github.com/openshift/instaslice-operator$ make test-e2e-ocp-emulated

@harche
Copy link
Contributor

harche commented Jan 17, 2025

Cert manager failed to installed because of the incorrect version.

- message: 'constraints not satisfiable: no operators found with name cert-manager-operator.v1.13.0
        in channel stable-v1 of package openshift-cert-manager-operator in the catalog
        referenced by subscription openshift-cert-manager-operator, subscription openshift-cert-manager-operator
        exists'

for testing using OCP 4.17 the correct version of cert manager would be, v1.14.1 from channel stable-v1.14 https://github.com/openshift/instaslice-operator/pull/380/files#diff-af319d5c0a1fbea8bc7acaeaeead1cf8ad8a78b12d96a202ce0ab8daf6dfd86cR24

@harche
Copy link
Contributor

harche commented Jan 17, 2025

@cpmeadors feel free to cherry-pick cd90963 into this PR.

@cpmeadors
Copy link
Contributor Author

@cpmeadors feel free to cherry-pick cd90963 into this PR.

I duplicated your changes. Thanks.

Copy link

openshift-ci bot commented Jan 17, 2025

@cpmeadors: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants