-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix base files and regenerate bundle-ocp and dockerfile #384
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpmeadors The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
00348aa
to
1d46fd8
Compare
/retest |
Unfortunately still fails with same error,
|
Also, the openshift cert manager operator didn't get installed as well, harshal@fedora:~/go/src/github.com/openshift/instaslice-operator$ oc get pods -n cert-manager
No resources found in cert-manager namespace.
harshal@fedora:~/go/src/github.com/openshift/instaslice-operator$ oc get pods -n cert-manager-operator
No resources found in cert-manager-operator namespace.
harshal@fedora:~/go/src/github.com/openshift/instaslice-operator$ for the record I invoked the tests by, harshal@fedora:~/go/src/github.com/openshift/instaslice-operator$ export IMG=quay.io/harpatil/instaslice2-controller:1.1
harshal@fedora:~/go/src/github.com/openshift/instaslice-operator$ export IMG_DMST=quay.io/harpatil/instaslice2-daemonset:1.1
harshal@fedora:~/go/src/github.com/openshift/instaslice-operator$ export BUNDLE_IMG=quay.io/harpatil/instaslice-bundle:1.1
harshal@fedora:~/go/src/github.com/openshift/instaslice-operator$ make test-e2e-ocp-emulated |
Cert manager failed to installed because of the incorrect version.
for testing using OCP 4.17 the correct version of cert manager would be, |
@cpmeadors feel free to cherry-pick cd90963 into this PR. |
cert-manager version
1d46fd8
to
80c4cdd
Compare
I duplicated your changes. Thanks. |
@cpmeadors: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
this catches up the generated bundle for ocp with the code.
Include version bumps for cert-manager deployment scripts