This repository has been archived by the owner on Dec 9, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 372
Add node playbook and tasks #34
Merged
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e7296d9
fixes of read me for 3.3 and paths
cooktheryan ad054ef
increase wait for route propagation
cooktheryan 232b70b
README patchup
cooktheryan 1b426c8
Merge branch 'master' of https://github.com/cooktheryan/openshift-ans…
cooktheryan 3b6fc21
WIP: add node playbooks
cooktheryan da3619a
syntax error
cooktheryan f9a2ea9
fix up of host up playbook
cooktheryan 73f4936
scale the router/registry
cooktheryan 3fabcb7
change of wording in add-node.py
cooktheryan 3e095b7
change of trigger name
cooktheryan 4d1fced
fix of existing_sg to node_sg
cooktheryan 6ac7ad9
needed to switch to the default project
cooktheryan 6c3bb73
moving things around for the load balancer
cooktheryan 26a9609
dont wait on elb and suggestion for removing changed in regards to su…
cooktheryan f905298
rhui wasn't being disabled using subscription-manager solved using file
cooktheryan 4db2970
disable repos rather than remove
cooktheryan 73226da
patchup
cooktheryan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,3 +8,12 @@ | |
- rhel-7-server-rpms | ||
- rhel-7-server-extras-rpms | ||
- rhel-7-server-ose-3.3-rpms | ||
|
||
- name: remove rhui repos | ||
file: | ||
path: "{{ item }}" | ||
state: absent | ||
with_items: | ||
- /etc/yum.repos.d/redhat-rhui-client-config.repo | ||
- /etc/yum.repos.d/redhat-rhui.repo | ||
- /etc/yum.repos.d/rhui-load-balancers.conf | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you can drop rhui-load-balancers.conf from the list, otherwise lgtm |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to disable these using yum-config-manger instead?
You could also leverage the rhui repos for base/extra packages (would need to enable rhui extras), and only use rhsm repos for the ose packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rhui killed all of my playbook runs this morning due to a missing CDS. I could always do a regex or replace to disable the repo in the file. It doesn't look like yum-config-manager bites in disabling these repos sadly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arrgh, of course it doesn't.... I do think disabling rather than removing the repo config is probably a better choice, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 It may have been a rage commit 🗡️ fix-up coming soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disabling is now more sane