Git server role

[sabre1041]

What does this PR do?

Adds a role to create a httpd backed git server

How should this be manually tested?

Create a git host group containing target machines and a playbook with the following contents

- name: Creates Git Server
  hosts: git
  roles:
  - role: git-server

Is there a relevant Issue open for this?

None

Who would you like to review this?

/cc @detiber @etsauer @oybed

[detiber]

Only comment I have is that the README should probably mention that this role should be deployed on a system that is not part of the OpenShift cluster, since it requires firewalld.

[sabre1041]

@detiber added content to README as requested

[oybed]

@sabre1041 LGTM

[sabre1041]

@oybed @detiber After a few more validations with ansible 2.0, added additional filter to prevent errors with undefined authorized keys

[detiber]

Unless 1.9 support is needed here, I would suggest using the package module here.

If 1.9 support is needed, should probably define ansible_pkg_mgr in vars/main.yaml for the role.

Otherwise, lgtm.

[oybed]

@detiber @sabre1041 good point about which versions are supported. Maybe we should just note that in the README for which version of Ansible the implementation has been tested with and/or intended for use with. Hence leaving it up to the author for what they'd like to support. Thoughts?

[sabre1041]

@detiber @oybed I added a compatibility section describing the ansible version the role was tested against

[detiber]

@sabre1041 lgtm unless @oybed has any outstanding items, I'm ready to merge.

[oybed]

@sabre1041 thank you for adding the compatibility section - LGTM. I'll go ahead and merge.