Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Remove the duplicate unit/psm target #270

Conversation

timflannagan
Copy link
Contributor

@timflannagan timflannagan commented Mar 28, 2022

Follow-up to openshift/release#27305 which moved the PSM unit tests to it's own dedicated prowjob in 4.11+.

Signed-off-by: timflannagan [email protected]

@openshift-ci openshift-ci bot requested review from dinhxuanvu and joelanford March 28, 2022 15:01
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2022
@exdx
Copy link
Contributor

exdx commented Mar 28, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 28, 2022
@timflannagan
Copy link
Contributor Author

These changes are essentially a no-op so I'm overriding the failing e2e tests.

/override ci/prow/e2e-gcp-olm
/override ci/prow/e2e-gcp-olm-flaky
/override ci/prow/e2e-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 28, 2022

@timflannagan: Overrode contexts on behalf of timflannagan: ci/prow/e2e-gcp-olm, ci/prow/e2e-gcp-olm-flaky, ci/prow/e2e-upgrade

In response to this:

These changes are essentially a no-op so I'm overriding the failing e2e tests.

/override ci/prow/e2e-gcp-olm
/override ci/prow/e2e-gcp-olm-flaky
/override ci/prow/e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 28, 2022

@timflannagan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 60a25a5 into openshift:master Mar 28, 2022
perdasilva pushed a commit to perdasilva/operator-framework-olm that referenced this pull request Mar 7, 2023
* update k8s 1.25 validation logic

to look for deprecated k8s APIs in various CSV fields

Signed-off-by: Bryce Palmer <[email protected]>

* update validation logic

Signed-off-by: Bryce Palmer <[email protected]>

* remove debug statements

Signed-off-by: Bryce Palmer <[email protected]>

Signed-off-by: Bryce Palmer <[email protected]>
Upstream-repository: api
Upstream-commit: b611f6cef49cb8c6d621145c4e31d8ddfd4c59f4
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Mar 15, 2023
* update k8s 1.25 validation logic

to look for deprecated k8s APIs in various CSV fields

Signed-off-by: Bryce Palmer <[email protected]>

* update validation logic

Signed-off-by: Bryce Palmer <[email protected]>

* remove debug statements

Signed-off-by: Bryce Palmer <[email protected]>

Signed-off-by: Bryce Palmer <[email protected]>
Upstream-repository: api
Upstream-commit: b611f6cef49cb8c6d621145c4e31d8ddfd4c59f4
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Mar 28, 2023
* update k8s 1.25 validation logic

to look for deprecated k8s APIs in various CSV fields

Signed-off-by: Bryce Palmer <[email protected]>

* update validation logic

Signed-off-by: Bryce Palmer <[email protected]>

* remove debug statements

Signed-off-by: Bryce Palmer <[email protected]>

Signed-off-by: Bryce Palmer <[email protected]>
Upstream-repository: api
Upstream-commit: b611f6cef49cb8c6d621145c4e31d8ddfd4c59f4
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Apr 6, 2023
* update k8s 1.25 validation logic

to look for deprecated k8s APIs in various CSV fields

Signed-off-by: Bryce Palmer <[email protected]>

* update validation logic

Signed-off-by: Bryce Palmer <[email protected]>

* remove debug statements

Signed-off-by: Bryce Palmer <[email protected]>

Signed-off-by: Bryce Palmer <[email protected]>
Upstream-repository: api
Upstream-commit: b611f6cef49cb8c6d621145c4e31d8ddfd4c59f4
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request May 23, 2023
* update k8s 1.25 validation logic

to look for deprecated k8s APIs in various CSV fields

Signed-off-by: Bryce Palmer <[email protected]>

* update validation logic

Signed-off-by: Bryce Palmer <[email protected]>

* remove debug statements

Signed-off-by: Bryce Palmer <[email protected]>

Signed-off-by: Bryce Palmer <[email protected]>
Upstream-repository: api
Upstream-commit: b611f6cef49cb8c6d621145c4e31d8ddfd4c59f4
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Jul 11, 2023
* update k8s 1.25 validation logic

to look for deprecated k8s APIs in various CSV fields

Signed-off-by: Bryce Palmer <[email protected]>

* update validation logic

Signed-off-by: Bryce Palmer <[email protected]>

* remove debug statements

Signed-off-by: Bryce Palmer <[email protected]>

Signed-off-by: Bryce Palmer <[email protected]>
Upstream-repository: api
Upstream-commit: b611f6cef49cb8c6d621145c4e31d8ddfd4c59f4
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Jul 17, 2023
* update k8s 1.25 validation logic

to look for deprecated k8s APIs in various CSV fields

Signed-off-by: Bryce Palmer <[email protected]>

* update validation logic

Signed-off-by: Bryce Palmer <[email protected]>

* remove debug statements

Signed-off-by: Bryce Palmer <[email protected]>

Signed-off-by: Bryce Palmer <[email protected]>
Upstream-repository: api
Upstream-commit: b611f6cef49cb8c6d621145c4e31d8ddfd4c59f4
tmshort pushed a commit to tmshort/operator-framework-olm that referenced this pull request Jul 20, 2023
* update k8s 1.25 validation logic

to look for deprecated k8s APIs in various CSV fields

Signed-off-by: Bryce Palmer <[email protected]>

* update validation logic

Signed-off-by: Bryce Palmer <[email protected]>

* remove debug statements

Signed-off-by: Bryce Palmer <[email protected]>

Signed-off-by: Bryce Palmer <[email protected]>
Upstream-repository: api
Upstream-commit: b611f6cef49cb8c6d621145c4e31d8ddfd4c59f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants