Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][release-4.14] OCPBUGS-48663: Fix concurrent namespace resolution #949

Open
wants to merge 4 commits into
base: release-4.14
Choose a base branch
from
Open

[WIP][release-4.14] OCPBUGS-48663: Fix concurrent namespace resolution #949

wants to merge 4 commits into from

Conversation

perdasilva
Copy link
Contributor

This is a manual cherry-pick of #948

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2025
@perdasilva perdasilva changed the title [release-4.14] OCPBUGS-XXXXX: Fix concurrent namespace resolution [release-4.14] OCPBUGS-48663: Fix concurrent namespace resolution Jan 21, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 21, 2025
@openshift-ci-robot
Copy link

@perdasilva: This pull request references Jira Issue OCPBUGS-48663, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-48662 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #948

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@perdasilva
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

@perdasilva: This pull request references Jira Issue OCPBUGS-48663, which is invalid:

  • expected dependent Jira Issue OCPBUGS-48662 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

joelanford and others added 3 commits January 21, 2025 10:31
@joelanford
🐛 Switch queue informer to use types.Namespace name; relocate deletio…
4fb82db 
…n handler (#3483)

* switch queue informer to use types.NamespacedName; relocate deletion handler

Signed-off-by: Joe Lanford <[email protected]>

* Add error message to object count assertion failure

Signed-off-by: Per Goncalves da Silva <[email protected]>

---------

Signed-off-by: Joe Lanford <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
Co-authored-by: Per Goncalves da Silva <[email protected]>
Upstream-repository: operator-lifecycle-manager
Upstream-commit: edb751b9718ffe29e8462ce17867ec3db3b349ff
[CARRY] fixup ns labeler plugin
8079389 
Signed-off-by: Per Goncalves da Silva <[email protected]>
[CARRY] address lint issues in namespace labeler plugin
10e0bf9 
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva
Copy link
Contributor Author

/retest

@perdasilva perdasilva force-pushed the workqueue-fix-414 branch 2 times, most recently from 17529de to b1578df Compare January 21, 2025 16:44
@perdasilva perdasilva changed the title [release-4.14] OCPBUGS-48663: Fix concurrent namespace resolution [WIP][release-4.14] OCPBUGS-48663: Fix concurrent namespace resolution Jan 21, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2025
@perdasilva
Copy link
Contributor Author

/retest

1 similar comment
@perdasilva
Copy link
Contributor Author

/retest

@kuiwang02
Copy link

/label cherry-pick-approved
/label qe-approved

@openshift-ci openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. qe-approved Signifies that QE has signed off on this PR labels Jan 23, 2025
@openshift-ci-robot
Copy link

@perdasilva: This pull request references Jira Issue OCPBUGS-48663, which is invalid:

  • expected dependent Jira Issue OCPBUGS-48662 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is a manual cherry-pick of #948

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[CARRY] address gc queue problem
a9dfa79 
Signed-off-by: Per Goncalves da Silva <[email protected]>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 29, 2025

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@oceanc80 oceanc80 Awaiting requested review from oceanc80

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@perdasilva @openshift-ci-robot @kuiwang02 @joelanford