-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Names for examples should be consistent across build configs and deployment configs #3358
Comments
@smarterclayton All the sample repos have been updated. Close or advise of additional changes at your discretion. Thanks. |
Can you link the fixes you made to this issue? |
cakephp-ex : sclorg/cakephp-ex#10 |
One thing - when someone deploys these examples, are they going to then 2015-07-02 15:18 GMT-04:00 Gabe Montero [email protected]:
Clayton Coleman | Lead Engineer, OpenShift |
Hmm ... has there been any thought to, or how feasible is it to have, a variable substitution mechanism for these json files' contents? Especially if the name is the only variable, and folks will want to use them as-is otherwise. It would be somewhat analogous to setting ENV vars in the JSON for runtime use in the containers. |
yes the names are all parameterizable just like we do with the DB side, like here: so we could do the same for the rest of the names (with useful defaults). @gabemontero if you want to open a new issue to track doing that and we can queue it up. |
3571 is opened: #3571 |
In our examples, when we have multiple components (a build config for a frontend and a deployment config for a frontend and backend) the build config, deployment config, service name, and route name should all match.
Example, nodejs.json:
It's hard to switch between these mentally - it would be better if we were consistent, nodejs-example completely or nodejs-frontend completely.
The text was updated successfully, but these errors were encountered: