Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare object DN to BaseDN using structured comparison #12105

Merged
merged 2 commits into from
Dec 4, 2016
Merged

Compare object DN to BaseDN using structured comparison #12105

merged 2 commits into from
Dec 4, 2016

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Dec 1, 2016 •
edited
Loading

@liggitt
Copy link
Contributor Author

liggitt commented Dec 1, 2016

[test]

@liggitt
Copy link
Contributor Author

liggitt commented Dec 1, 2016 •
edited
Loading

[testextended][extended:ldap_groups]

@liggitt liggitt mentioned this pull request Dec 1, 2016
Closed
@enj
Copy link
Contributor

enj commented Dec 1, 2016

Nice. LGTM.

@soltysh
Copy link
Contributor

soltysh commented Dec 1, 2016

LGTM

@stevekuznetsov
Copy link
Contributor

I think you'll also need [testextended]

@stevekuznetsov
Copy link
Contributor

@openshift-bot, the last build failed from the following flakes:

re-[testextended]

@liggitt
Copy link
Contributor Author

liggitt commented Dec 1, 2016

re[test]

@liggitt
Copy link
Contributor Author

liggitt commented Dec 2, 2016

ldap extended test passes, hit error publishing junit results

[merge]

@liggitt liggitt mentioned this pull request Dec 2, 2016
Merged
@mfojtik
Copy link
Contributor

mfojtik commented Dec 2, 2016

thanks @liggitt !

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to c89bd66

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to c89bd66

@openshift-bot
Copy link
Contributor

Evaluated for origin testextended up to c89bd66

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/testextended SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin_extended/866/) (Base Commit: 4c59faf) (Extended Tests: ldap_groups)

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11978/) (Base Commit: 4c59faf)

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 4, 2016 •
edited
Loading

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11985/) (Base Commit: f20ac82) (Image: devenv-rhel7_5480)

@openshift-bot openshift-bot merged commit ab362f6 into openshift:master Dec 4, 2016
@liggitt liggitt deleted the ldap-fix branch December 5, 2016 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@liggitt @enj @soltysh @stevekuznetsov @mfojtik @openshift-bot