Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark tests that use docker socket as [local] #20077

Merged
merged 1 commit into from
Jun 22, 2018
Merged

mark tests that use docker socket as [local] #20077

merged 1 commit into from
Jun 22, 2018

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Jun 22, 2018

No description provided.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 22, 2018
@bparees
Copy link
Contributor Author

bparees commented Jun 22, 2018

@legionus @dmage @miminar fyi

@bparees bparees added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2018
@miminar miminar mentioned this pull request Jun 22, 2018
Open
miminar
miminar approved these changes Jun 22, 2018
View reviewed changes
Copy link

@miminar miminar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Here's the issue for rewriting the tests: #20061

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, miminar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 84c76c1 into openshift:master Jun 22, 2018
@bparees bparees deleted the hardprune branch June 23, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miminar miminar miminar approved these changes

@gabemontero gabemontero Awaiting requested review from gabemontero

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@miminar miminar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bparees @openshift-ci-robot @miminar @openshift-merge-robot