Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1846428: UPSTREAM: 90419: Update strategy used to reuse CPUs from init containers in CPUManager #25090

Closed

Conversation

cynepco3hahue
Copy link
Contributor

ref: kubernetes/kubernetes#90419

Signed-off-by: Artyom Lukianov [email protected]

@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Jun 10, 2020
@cynepco3hahue
Copy link
Contributor Author

@vpickard Can you please provide the relevant Bugzilla?

@cynepco3hahue
Copy link
Contributor Author

/assign rphillips

@cynepco3hahue cynepco3hahue changed the title UPSTREAM <90419>: Update strategy used to reuse CPUs from init containers in CPUManager UPSTREAM: 90419: Update strategy used to reuse CPUs from init containers in CPUManager Jun 10, 2020
@cynepco3hahue
Copy link
Contributor Author

/retest

@cynepco3hahue
Copy link
Contributor Author

/retest

3 similar comments
@cynepco3hahue
Copy link
Contributor Author

/retest

@cynepco3hahue
Copy link
Contributor Author

/retest

@cynepco3hahue
Copy link
Contributor Author

/retest

@vpickard
Copy link

/bugzilla refresh

@openshift-ci-robot
Copy link

@vpickard: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cynepco3hahue cynepco3hahue changed the title UPSTREAM: 90419: Update strategy used to reuse CPUs from init containers in CPUManager Bug 1846428: UPSTREAM: 90419: Update strategy used to reuse CPUs from init containers in CPUManager Jun 11, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 11, 2020
@openshift-ci-robot
Copy link

@cynepco3hahue: This pull request references Bugzilla bug 1846428, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1846428: UPSTREAM: 90419: Update strategy used to reuse CPUs from init containers in CPUManager

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cynepco3hahue
Copy link
Contributor Author

/bugzilla

@vpickard
Copy link

/bugzilla refresh

@openshift-ci-robot
Copy link

@vpickard: This pull request references Bugzilla bug 1846428, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cynepco3hahue
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link

@cynepco3hahue: This pull request references Bugzilla bug 1846428, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vpickard
Copy link

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 11, 2020
@cynepco3hahue
Copy link
Contributor Author

/retest

6 similar comments
@cynepco3hahue
Copy link
Contributor Author

/retest

@cynepco3hahue
Copy link
Contributor Author

/retest

@cynepco3hahue
Copy link
Contributor Author

/retest

@cynepco3hahue
Copy link
Contributor Author

/retest

@cynepco3hahue
Copy link
Contributor Author

/retest

@cynepco3hahue
Copy link
Contributor Author

/retest

@cynepco3hahue
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2020
@cynepco3hahue
Copy link
Contributor Author

@sjenning @rphillips The PR is ready for review, can you please take a look?

@cynepco3hahue
Copy link
Contributor Author

/retest

2 similar comments
@cynepco3hahue
Copy link
Contributor Author

/retest

@cynepco3hahue
Copy link
Contributor Author

/retest

@vpickard
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cynepco3hahue, vpickard
To complete the pull request process, please assign knobunc
You can assign the PR to them by writing /assign @knobunc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vpickard
Copy link

/assign @knobunc

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2020
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@ffromani
Copy link
Contributor

/retest

1 similar comment
@cynepco3hahue
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 21, 2020

@cynepco3hahue: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify-deps 1700e94 link /test verify-deps
ci/prow/e2e-aws-fips 1700e94 link /test e2e-aws-fips
ci/prow/e2e-gcp-upgrade 1700e94 link /test e2e-gcp-upgrade
ci/prow/e2e-cmd 1700e94 link /test e2e-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cynepco3hahue
Copy link
Contributor Author

The fix will be available for free after the rebase on top of 1.19.

@openshift-ci-robot
Copy link

@cynepco3hahue: This pull request references Bugzilla bug 1846428. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Bug 1846428: UPSTREAM: 90419: Update strategy used to reuse CPUs from init containers in CPUManager

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants