OCPBUGS-45924: add a monitor test that detects concurrent installer pods #29382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tkashem The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tkashem
force-pushed
the
monitor-installer-pod
branch
from
16844b1 to
f6f032f
Compare
|
Job Failure Risk Analysis for sha: f6f032f
|
tkashem
force-pushed
the
monitor-installer-pod
branch
from
f6f032f to
d770b9f
Compare
|
Job Failure Risk Analysis for sha: d770b9f
|
tkashem
force-pushed
the
monitor-installer-pod
branch
from
d770b9f to
36711ce
Compare
tkashem
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Job Failure Risk Analysis for sha: 36711ce
|
|
/payload |
|
/payload 4.18 nightly informing |
|
@tkashem: trigger 68 job(s) of type informing for the nightly release of OCP 4.18
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dfdef9b0-bdbf-11ef-98ca-f9166c462206-0 |
tkashem
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@tkashem: This pull request references Jira Issue OCPBUGS-45924, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
tkashem
changed the title
|
/retest |
1 similar comment
|
/retest |
|
@tkashem: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Job Failure Risk Analysis for sha: a051b38
|
vrutkovs
reviewed
Jan 2, 2025
| pods: map[string]*podInfo{}, | ||
| }, | ||
| filter: func(interval monitorapi.Interval) bool { | ||
| if ns, ok := interval.Locator.Keys[monitorapi.LocatorNamespaceKey]; !ok || ns != "openshift-etcd" { |
There was a problem hiding this comment.
imo this should be moved to openshift-etcd and renamed to include "etcd" prefix as we may want to later expand this to other installers like kube-apiserver
| endedAt = info.startedAt | ||
| level = monitorapi.Error | ||
| } | ||
| if info.lastReason == "Killing" || info.concurrent { |
There was a problem hiding this comment.
Killing here means installer failed with error or took longer than timeout?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
examine the events associated with the installer Pods, do the following:
a) construct an e2e timeline
b) detect if installer pods are running concurrently on two nodes, and return a flaking test
we want to know how widespread
bis.installer pod timeline:
and the test will flake if it finds concurrent installer pods on two or more nodes, this is how it would look like (simulated, not an actual occurrence):