Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-47700: images: Fix layers test to work with manifestlisted imagestreams #29392

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Prashanth684
Copy link

Look at the layers in the submanifest rather than the top level manifest if the imagestream is manifestlisted. Refer to the bug for details.

This fixes techpreview jobs for clusters installed with the multi-payload. Example of a failure: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-multiarch-master-nightly-4.19-ocp-e2e-aws-ovn-techpreview-multi-a-a/1873687894279852032

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 30, 2024
@openshift-ci-robot
Copy link

@Prashanth684: This pull request references Jira Issue OCPBUGS-47700, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Look at the layers in the submanifest rather than the top level manifest if the imagestream is manifestlisted. Refer to the bug for details.

This fixes techpreview jobs for clusters installed with the multi-payload. Example of a failure: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-multiarch-master-nightly-4.19-ocp-e2e-aws-ovn-techpreview-multi-a-a/1873687894279852032

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 30, 2024
@flavianmissi
Copy link
Member

Test failures seem unrelated.
/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2025
Copy link
Contributor

openshift-ci bot commented Jan 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavianmissi, Prashanth684

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2025
Copy link

openshift-trt bot commented Jan 2, 2025

Job Failure Risk Analysis for sha: e6b2fbf

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node Low
[sig-node] static pods should start after being created
This test has passed 72.22% of 126 runs on jobs [periodic-ci-openshift-release-master-nightly-4.19-e2e-aws-ovn-single-node] in the last 14 days.
pull-ci-openshift-origin-master-e2e-aws-ovn-kube-apiserver-rollout Low
[Conformance][Suite:openshift/kube-apiserver/rollout][Jira:"kube-apiserver"][sig-kube-apiserver] kube-apiserver should roll out new revisions without disruption [apigroup:config.openshift.io][apigroup:operator.openshift.io]
This test has passed 50.00% of 6 runs on release 4.19 [Architecture:amd64 FeatureSet:default Installer:ipi Network:ovn NetworkStack:ipv4 Platform:aws SecurityMode:default Topology:ha Upgrade:none] in the last week.

@Prashanth684
Copy link
Author

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 3, 2025
Copy link
Contributor

openshift-ci bot commented Jan 3, 2025

New changes are detected. LGTM label has been removed.

@Prashanth684
Copy link
Author

@flavianmissi added a change to the logic - we noticed that for clusters of non-x86 architectures running the multi payload, comparing the x86 manifest is not the correct approach - so now each of the submanifest layers are matched to see if one of them match to ensure that it works on any architecture cluster (not just x86).

Look at the layers in the submanifest rather than the top level manifest
if the imagestream is manifestlisted. Refer to the bug for details.

This fixes techpreview jobs for clusters installed with the
multi-payload. Example of a failure: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-multiarch-master-nightly-4.19-ocp-e2e-aws-ovn-techpreview-multi-a-a/1873687894279852032
@Prashanth684
Copy link
Author

/test unit

@Prashanth684
Copy link
Author

/retest

Copy link
Contributor

openshift-ci bot commented Jan 4, 2025

@Prashanth684: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 1f6155b link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants