-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-47700: images: Fix layers test to work with manifestlisted imagestreams #29392
base: master
Are you sure you want to change the base?
Conversation
@Prashanth684: This pull request references Jira Issue OCPBUGS-47700, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Test failures seem unrelated. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flavianmissi, Prashanth684 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Job Failure Risk Analysis for sha: e6b2fbf
|
/retest |
e6b2fbf
to
1f6155b
Compare
New changes are detected. LGTM label has been removed. |
@flavianmissi added a change to the logic - we noticed that for clusters of non-x86 architectures running the multi payload, comparing the x86 manifest is not the correct approach - so now each of the submanifest layers are matched to see if one of them match to ensure that it works on any architecture cluster (not just x86). |
Look at the layers in the submanifest rather than the top level manifest if the imagestream is manifestlisted. Refer to the bug for details. This fixes techpreview jobs for clusters installed with the multi-payload. Example of a failure: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-multiarch-master-nightly-4.19-ocp-e2e-aws-ovn-techpreview-multi-a-a/1873687894279852032
/test unit |
/retest |
@Prashanth684: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Look at the layers in the submanifest rather than the top level manifest if the imagestream is manifestlisted. Refer to the bug for details.
This fixes techpreview jobs for clusters installed with the multi-payload. Example of a failure: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-multiarch-master-nightly-4.19-ocp-e2e-aws-ovn-techpreview-multi-a-a/1873687894279852032