Added readiness probe for Router

[miminar]

Uses the same endpoint as liveness probe does.

Partially addresses #5900

Signed-off-by: Michal Minar [email protected]

[miminar]

@Kargakis could you please take a look?

[0xmichalis]

LGTM

cc: @pweil-

[pweil-]

We should use the new healthz handler to detect liveness and readiness. https://github.com/openshift/origin/blob/master/images/router/haproxy/conf/haproxy-config.template#L46-46

cc @ramr - we landed on this always being available, right?

[miminar]

@pweil- thanks for pointing that out. I've just switched to this route in both liveness and readiness probes.

[miminar]

cc: @smarterclayton

[smarterclayton]

I think @ramr had to make it always available still - or Ben was going to do it?

[ramr]

@pweil- @smarterclayton yeah was going to the /healthz endpoint always available - probably get to it in the next couple of days. For now, this code looks good and will change it along with the PR for that - the if condition checking for config.StatsPort would become redundant at that point and the else part would just drop off and can be deleted.

[smarterclayton]

Thanks, LGTM [merge]

[openshift-bot]

[Test]ing while waiting on the merge queue

[openshift-bot]

Evaluated for origin test up to 595572a

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin/7226/)

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4055/) (Image: devenv-rhel7_2741)

[0xmichalis]

#5937 flake

re[merge]

[openshift-bot]

Evaluated for origin merge up to 595572a