Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registry's Azure Driver #6378

Merged
merged 2 commits into from
Jan 21, 2016
Merged

Registry's Azure Driver #6378

merged 2 commits into from
Jan 21, 2016

Conversation

spinolacastro
Copy link
Contributor

No description provided.

@pweil-
Copy link

pweil- commented Dec 17, 2015

Depends on #5404

@miminar
Copy link

miminar commented Dec 18, 2015

@spinolacastro: #5404 is merged now. You may safely rebase on top of master.

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 18, 2015
@spinolacastro
Copy link
Contributor Author

@miminar,@pweil- Done!

@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2015
@spinolacastro spinolacastro force-pushed the registry-azure branch 3 times, most recently from b2f4f03 to 5d6410a Compare December 21, 2015 13:22
@miminar
Copy link

miminar commented Dec 21, 2015

LGTM

@miminar
Copy link

miminar commented Dec 21, 2015

[test]

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2016
@miminar
Copy link

miminar commented Jan 14, 2016

[test]
@pweil- I believe this is good to go. Do we need to document it somewhere?

@pweil-
Copy link

pweil- commented Jan 14, 2016

@miminar - the relevant place would be https://docs.openshift.org/latest/install_config/install/docker_registry.html#storage-for-the-registry but I don't see driver information there now. Couldn't hurt to add in the supported drivers. I would've guessed we had at least an s3 example somewhere but didn't see it right away.

@pweil-
Copy link

pweil- commented Jan 14, 2016

LGTM - @smarterclayton, should we wait until 3.1.1 is cut (I'm assuming yes)?

@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2016
@smarterclayton
Copy link
Contributor

Yes, will merge right after and will be in 1.1.2

@pweil-
Copy link

pweil- commented Jan 15, 2016

re[test]

@smarterclayton
Copy link
Contributor

[test]

On Thu, Jan 14, 2016 at 10:05 PM, OpenShift Bot [email protected]
wrote:

continuous-integration/openshift-jenkins/test FAILURE (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/19/)

—
Reply to this email directly or view it on GitHub
#6378 (comment).

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to a11e8fc

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/49/)

@smarterclayton
Copy link
Contributor

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/4684/) (Image: devenv-rhel7_3198)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to a11e8fc

openshift-bot pushed a commit that referenced this pull request Jan 21, 2016
Merge pull request #6378 from getupcloud/registry-azure
189e202 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit 189e202 into openshift:master Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spinolacastro @pweil- @miminar @smarterclayton @openshift-bot