Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: MON-4104: Update to 3.0 #227

Open
wants to merge 775 commits into
base: main
Choose a base branch
from
Open

WIP: MON-4104: Update to 3.0 #227

wants to merge 775 commits into from

Conversation

machine424
Copy link

@machine424 machine424 commented Sep 25, 2024 •
edited
Loading

to do:

  • keep our new gitignore (synbot)
  • update synbot commands
  • remove remote-write-receiver feature flag setting in CMO
  • auto-gomemlimit and autogomaxprocs? (SNO)
  • fallback_scrape_protocol
  • run some extra palyload tests

To reviewer:
too many commits, please give more attention to the ones I added on top

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 25, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: machine424

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2024
roidelapluie and others added 25 commits October 7, 2024 10:50
@roidelapluie
Merge pull request prometheus#15042 from prometheus/dependabot/go_mod…
989db7b 
…ules/go.uber.org/automaxprocs-1.6.0

Bump go.uber.org/automaxprocs from 1.5.3 to 1.6.0
@bwplotka
textparse: Refactored benchmark (prometheus#15083)
8d281c3 
* textparse: Refactored benchmark.

Signed-off-by: bwplotka <[email protected]>

* Kill sinks, tested, nothing is inlined.

Signed-off-by: bwplotka <[email protected]>

* Addressed comments.

Signed-off-by: bwplotka <[email protected]>

---------

Signed-off-by: bwplotka <[email protected]>
@roidelapluie
Merge pull request prometheus#15113 from yeya24/add-missing-allow-ove…
9d8f93e 
…rlapping-compaction-flag

Add missing flag storage.tsdb.allow-overlapping-compaction
@krajorama
Merge branch 'main' into nhcb-scrape-impl
ed2e7dc 
# Conflicts:
#	scrape/scrape.go
@krajorama
Rename bType to bName as Type returns the binary name and not the typ…
9c4816d 
…e name

See Parser.Type() function.

Signed-off-by: György Krajcsovits <[email protected]>
@roidelapluie
Merge pull request prometheus#15039 from prometheus/dependabot/go_mod…
b3f6019 
…ules/google.golang.org/grpc-1.67.1

Bump google.golang.org/grpc from 1.66.0 to 1.67.1
@roidelapluie
Merge pull request prometheus#15043 from prometheus/dependabot/go_mod…
a42e847 
…ules/golang.org/x/tools-0.25.0

Bump golang.org/x/tools from 0.24.0 to 0.25.0
@dependabot
build(deps): bump golang.org/x/tools from 0.25.0 to 0.26.0
b062dfa 
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.25.0 to 0.26.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.25.0...v0.26.0)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@roidelapluie
Merge pull request prometheus#15117 from prometheus/dependabot/go_mod…
1df86df 
…ules/golang.org/x/tools-0.26.0

build(deps): bump golang.org/x/tools from 0.25.0 to 0.26.0
@roidelapluie
Merge pull request prometheus#15038 from prometheus/dependabot/go_mod…
2b4ca98 
…ules/github.com/gophercloud/gophercloud-1.14.1

Bump github.com/gophercloud/gophercloud from 1.14.0 to 1.14.1
@bwplotka
textparse: Refactored main testing utils for reusability; fixed proto…
f6e110d 
… Units. (prometheus#15095)

Signed-off-by: bwplotka <[email protected]>
@krajorama
Add unit test nhcbparse_test.go
e1a7008 
Signed-off-by: György Krajcsovits <[email protected]>
@krajorama
Merge branch 'main' into nhcb-scrape-impl
e0444d9
@roidelapluie
Document the notifications API
db730fc 
Signed-off-by: Julien <[email protected]>
@beorn7
docs: Declare "float literals are time durations" as stable
08d4b03 
This unifies the documentation of float literals and time durations
and updates all references to the old definitions.

Signed-off-by: beorn7 <[email protected]>
@krajorama
Make nhcb unit test pass with many exceptions marked as TODOs
2a3aa50 
Signed-off-by: György Krajcsovits <[email protected]>
@roidelapluie
docs: extract HTTP client option documentation from scrape config
261d7d7 
Extracted HTTP client options (e.g., authentication, proxy settings,
TLS configuration, and custom headers) into a dedicated section for
improved clarity and organization. This will centralize all HTTP-related
options from prometheus/common in one place within the documentation.

The remaining HTTP-related settings in sections (e.g. Service Discovery)
will be moved in a follow-up PR to further unify the documentation
structure.

Signed-off-by: Julien <[email protected]>
@bboreham
[BUGFIX] TSDB: Don't read in-order chunks from before head MinTime
91de19f 
Because we are reimplementing the `IndexReader` to fetch in-order and
out-of-order chunks together, we must reproduce the behaviour of
`Head.indexRange()`, which floors the minimum time queried at `head.MinTime()`.

Signed-off-by: Bryan Boreham <[email protected]>
@roidelapluie
Remove http options from remote read/write
e7206c2 
Signed-off-by: Julien <[email protected]>
@roidelapluie
Remove HTTP options from alerting
6acf2dc 
Signed-off-by: Julien <[email protected]>
@roidelapluie
Remove HTTP options from vultr
675349c 
Signed-off-by: Julien <[email protected]>
@roidelapluie
Remove http options from uyuni
aef84c0 
Signed-off-by: Julien <[email protected]>
@roidelapluie
Remove http options from Eureka and Scaleway
1dd45fd 
Signed-off-by: Julien <[email protected]>
@roidelapluie
Remove HTTP client doc from nomad and marathon
530c3fc 
Signed-off-by: Julien <[email protected]>
@roidelapluie
Remove http client docs from linode and lightsail
04b1201 
Signed-off-by: Julien <[email protected]>
@machine424
Copy link
Author

/testwith openshift/prometheus/master/e2e-agnostic-cmo openshift/cluster-monitoring-operator#2554
/testwith openshift/prometheus/master/e2e-aws-ovn openshift/cluster-monitoring-operator#2554
/testwith openshift/prometheus/master/e2e-aws-ovn-upgrade openshift/cluster-monitoring-operator#2554

@machine424 machine424 force-pushed the test-3.0 branch 2 times, most recently from f26e542 to 3dbee39 Compare January 9, 2025 16:55
@machine424
Copy link
Author

/testwith openshift/prometheus/master/e2e-agnostic-cmo openshift/cluster-monitoring-operator#2554
/testwith openshift/prometheus/master/e2e-aws-ovn openshift/cluster-monitoring-operator#2554
/testwith openshift/prometheus/master/e2e-aws-ovn-upgrade openshift/cluster-monitoring-operator#2554

@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 14, 2025
@machine424
Copy link
Author

/testwith openshift/prometheus/master/e2e-agnostic-cmo openshift/cluster-monitoring-operator#2554
/testwith openshift/prometheus/master/e2e-aws-ovn openshift/cluster-monitoring-operator#2554
/testwith openshift/prometheus/master/e2e-aws-ovn-upgrade openshift/cluster-monitoring-operator#2554

@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 15, 2025
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 15, 2025
@machine424 machine424 mentioned this pull request Jan 15, 2025
Open
2 tasks
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 15, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 15, 2025

@machine424: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade 76702ea link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-agnostic-cmo 76702ea link true /test e2e-agnostic-cmo
ci/prow/okd-scos-e2e-aws-ovn 76702ea link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 16, 2025

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2554
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-rosa-sts-hypershift-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/50647e70-d3fb-11ef-84ae-020c1e634813-0

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 16, 2025

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2554
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-rosa-sts-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6c58b6a0-d3fb-11ef-9ad3-ed24ac0f8204-0

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 16, 2025

@machine424: This PR was included in a payload test run from openshift/cluster-monitoring-operator#2554
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.19-e2e-rosa-sts-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/88b2b380-d411-11ef-93dc-3c642b2d31ff-0

@machine424
Copy link
Author

machine424 commented Jan 17, 2025 •
edited by openshift-ci bot
Loading

/retitle MON-4104: Update to 3.0

@openshift-ci openshift-ci bot changed the title Update to 3.0 MON-4104: Update to 3.0 Jan 17, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 17, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 17, 2025 •
edited by openshift-ci bot
Loading

@machine424: This pull request references MON-4104 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.19.0" version, but no target version was set.

In response to this:

to do:

  • keep our new gitignore (synbot)
  • update synbot commands
  • remove remote-write-receiver feature flag setting in CMO
  • auto-gomemlimit and autogomaxprocs? (SNO)
  • fallback_scrape_protocol
  • run some extra palyload tests

To reviewer:
too many commits, please give more attention to the ones I added on top

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@machine424 machine424 changed the title MON-4104: Update to 3.0 WIP: MON-4104: Update to 3.0 Jan 17, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmellado danielmellado Awaiting requested review from danielmellado

@jan--f jan--f Awaiting requested review from jan--f

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.