Netobserv CI config updates #53326
Netobserv CI config updates #53326
Conversation
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
| netobserv: | ||
| repos: | ||
| network-observability-operator: | ||
| unmanaged: true |
There was a problem hiding this comment.
any reason why we're removing prow to manage our protected branches? If I am understanding this correct, the tests jobs that are triggered on PRs looking to merge to main will no longer have tests as Required.
There was a problem hiding this comment.
I used to have our upstream unit tests as required, which I found better because they're faster to run and less susceptible to environmental issues. Not only prow's branch protection added more flakiness in required tests but also removed the previously defined required tests.
I prefer to manage them from upstream/github - and then we can have the discussion of what to set required or not.
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/pj-rehearse |
|
@memodi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@memodi, |
|
@memodi @jpinsonneau : rebased |
|
/pj-rehearse |
|
@jotak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest |
|
/pj-rehearse |
|
@jotak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@jotak seems it's not able to find the the golang-1.22 image with .ci-operator.yaml config, I think correct tag we need for golang-1.22 in that file is: |
|
@memodi yeah there's an issue with the tag but this is obscure, I don't even know which registry to look at. The error message says it's looking in quay.io, but I don't have access to that openshift repo there ; the documentation mentions tags like I did (their example is Where did you find the tag that you mention, |
|
/pj-rehearse pull-ci-netobserv-flowlogs-pipeline-main-images |
|
@jotak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Indeed, it's obscure and haven't found good way to peek at the registry before using the tags or without referring to some examples already in the repo for the image. Once I know the tag, I try to confirm by doing |
that example you linked is what you want to use, it appends the name and namespace with "_" automatically. |
|
ok it passed with flp, let's do the same on others :-) |
|
/pj-rehearse |
|
@jotak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
- Use build root config from repo - Disable redundant unit tests (they run from github actions) - Disable branch protection (managed from github) Signed-off-by: Joel Takvorian <[email protected]>
|
last pj-rehearse worked except for 3 that timed out |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse more |
|
@jotak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@jotak: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/pj-rehearse ack |
|
@jotak: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-ci-robot
added
the
rehearsals-ack
|
@jotak: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Needs upstream PRs: