Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator-sdk: bump to go 1.13 #5443

Merged
merged 1 commit into from
Oct 23, 2019

Conversation

joelanford
Copy link
Member

Bump go version for operator-sdk repos from 1.12 to 1.13 for master, release-4.3, and release-4.4 branches.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 15, 2019
@joelanford
Copy link
Member Author

/hold

Still need some team discussion on when to make this switch.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2019
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approved

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2019
@joelanford
Copy link
Member Author

/retest

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2019
@joelanford
Copy link
Member Author

/test pj-rehearse

@joelanford
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2019
Copy link
Contributor

@hasbro17 hasbro17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, hasbro17, joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7c114eb into openshift:master Oct 23, 2019
@openshift-ci-robot
Copy link
Contributor

@joelanford: Updated the following 6 configmaps:

  • ci-operator-4.4-configs configmap in namespace ci-stg using the following files:
    • key openshift-ocp-release-operator-sdk-release-4.4.yaml using file ci-operator/config/openshift/ocp-release-operator-sdk/openshift-ocp-release-operator-sdk-release-4.4.yaml
    • key operator-framework-operator-sdk-release-4.4.yaml using file ci-operator/config/operator-framework/operator-sdk/operator-framework-operator-sdk-release-4.4.yaml
  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-ocp-release-operator-sdk-master.yaml using file ci-operator/config/openshift/ocp-release-operator-sdk/openshift-ocp-release-operator-sdk-master.yaml
    • key operator-framework-operator-sdk-master.yaml using file ci-operator/config/operator-framework/operator-sdk/operator-framework-operator-sdk-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-ocp-release-operator-sdk-master.yaml using file ci-operator/config/openshift/ocp-release-operator-sdk/openshift-ocp-release-operator-sdk-master.yaml
    • key operator-framework-operator-sdk-master.yaml using file ci-operator/config/operator-framework/operator-sdk/operator-framework-operator-sdk-master.yaml
  • ci-operator-4.3-configs configmap in namespace ci using the following files:
    • key openshift-ocp-release-operator-sdk-release-4.3.yaml using file ci-operator/config/openshift/ocp-release-operator-sdk/openshift-ocp-release-operator-sdk-release-4.3.yaml
    • key operator-framework-operator-sdk-release-4.3.yaml using file ci-operator/config/operator-framework/operator-sdk/operator-framework-operator-sdk-release-4.3.yaml
  • ci-operator-4.3-configs configmap in namespace ci-stg using the following files:
    • key openshift-ocp-release-operator-sdk-release-4.3.yaml using file ci-operator/config/openshift/ocp-release-operator-sdk/openshift-ocp-release-operator-sdk-release-4.3.yaml
    • key operator-framework-operator-sdk-release-4.3.yaml using file ci-operator/config/operator-framework/operator-sdk/operator-framework-operator-sdk-release-4.3.yaml
  • ci-operator-4.4-configs configmap in namespace ci using the following files:
    • key openshift-ocp-release-operator-sdk-release-4.4.yaml using file ci-operator/config/openshift/ocp-release-operator-sdk/openshift-ocp-release-operator-sdk-release-4.4.yaml
    • key operator-framework-operator-sdk-release-4.4.yaml using file ci-operator/config/operator-framework/operator-sdk/operator-framework-operator-sdk-release-4.4.yaml

In response to this:

Bump go version for operator-sdk repos from 1.12 to 1.13 for master, release-4.3, and release-4.4 branches.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joelanford joelanford deleted the sdk-go1.13 branch October 23, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants