-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: add(odh-io/{kubeflow,notebooks}/plugin config): size plugin #60771
base: master
Are you sure you want to change the base?
Conversation
The size plugin maintains a label that signifies the size of a PR diff. There are labels ranging from xs to xxl, each applies to a certain range of changed lines.
@jiridanek: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[REHEARSALNOTIFIER] |
@jiridanek: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@jiridanek: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
The size plugin maintains a label that signifies the size of a PR diff. There are labels ranging from xs to xxl, each applies to a certain range of changed lines.
This should nudge contributors to prefer submitting multiple smaller PRs rather than submit small number of large PRs that then become difficult to review promptly.