Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: add(odh-io/{kubeflow,notebooks}/plugin config): size plugin #60771

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Jan 18, 2025

The size plugin maintains a label that signifies the size of a PR diff. There are labels ranging from xs to xxl, each applies to a certain range of changed lines.

This should nudge contributors to prefer submitting multiple smaller PRs rather than submit small number of large PRs that then become difficult to review promptly.

The size plugin maintains a label that signifies the size of a PR diff.
There are labels ranging from xs to xxl, each applies to a certain range of changed lines.
@openshift-ci-robot
Copy link
Contributor

@jiridanek: This pull request explicitly references no jira issue.

In response to this:

The size plugin maintains a label that signifies the size of a PR diff. There are labels ranging from xs to xxl, each applies to a certain range of changed lines.

This should nudge contributors to prefer submitting multiple smaller PRs rather than submit small number of large PRs that then become difficult to review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 18, 2025
@openshift-ci openshift-ci bot requested review from atheo89 and harshad16 January 18, 2025 09:06
Copy link
Contributor

openshift-ci bot commented Jan 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2025
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 18, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jiridanek: no rehearsable tests are affected by this change

Copy link
Contributor

openshift-ci bot commented Jan 18, 2025

@jiridanek: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

@jiridanek: This pull request explicitly references no jira issue.

In response to this:

The size plugin maintains a label that signifies the size of a PR diff. There are labels ranging from xs to xxl, each applies to a certain range of changed lines.

This should nudge contributors to prefer submitting multiple smaller PRs rather than submit small number of large PRs that then become difficult to review promptly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants