Require special approval for intentional regs in consecutive releases. #2262
Conversation
dgoodwin
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
First run will intentionally fail so we can see what it looks like. |
| "TestID": "openshift-tests:d6b41cee7afca1c2a0b52f9e6975425f", | ||
| "TestName": "[bz-kube-apiserver][invariant] alert/KubeAPIErrorBudgetBurn should not be at or above info", | ||
| "JiraBug": "https://issues.redhat.com/browse/OCPBUGS-42083", | ||
| "ReasonToAllowInsteadOfFix": "Degraded enough to trip test near the end of stabilization. Still no root cause determined, and the team is still actively investigating. We are marking this as not a blocker because we did not see signals indicating that this does not stabilize after install is completed, although that has not yet been confirmed.", |
There was a problem hiding this comment.
This is a straight dupe of 4.17 to trigger the failure, i'll remove once we see it work.
dgoodwin
force-pushed
the
block-consec-reg-allowance
branch
from
a9e013f to
5eac98f
Compare
dgoodwin
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Nit, could we get it to produce junits so it's more obvious in spyglass? |
It can also be a separate thing to do, it's not exactly related to this. /lgtm |
openshift-ci
bot
added
lgtm
Pushed a commit to try, I fear it wont be in the src image we use to run make test |
|
yup... |
openshift-merge-robot
added
the
needs-rebase
Surface the problem via a unit test which will fail PRs adding an intentional regression for two releases in a row, for the same test. To work past this, a new overrides.json file is added in a new directory with very limited approvers. Test output directs to a README in this directory signalling how to add to the overrides.json, and reach out to get approval.
dgoodwin
force-pushed
the
block-consec-reg-allowance
branch
from
aefc1db to
3eb2d7b
Compare
openshift-merge-robot
removed
the
needs-rebase
dgoodwin
force-pushed
the
block-consec-reg-allowance
branch
from
3eb2d7b to
41c82f4
Compare
|
Better failure now: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_sippy/2262/pull-ci-openshift-sippy-master-unit/1880027527498436608 PR updated to remove the forced failure now and should be ready for review. |
|
@dgoodwin: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dgoodwin, stbenjam The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Surface the problem via a unit test which will fail PRs adding an
intentional regression for two releases in a row, for the same test.
To work past this, a new overrides.json file is added in a new directory
with very limited approvers. Test output directs to a README in this
directory signalling how to add to the overrides.json, and reach out to
get approval.