Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD-960: Update Containers to UBI9 go-toolset #1145

Merged
merged 1 commit into from
May 16, 2024

Conversation

adambkaplan
Copy link
Contributor

  • Update Dockerfiles to use the ubi9 go-toolset images. For the releaser image, this avoids downloading the go sdk as part of the relase process.
  • Add build-container make target for convenience.
  • Update ci-operator build root to use rhel-9 golang 1.20 image for OCP 4.15

- Update Dockerfiles to use the ubi9 go-toolset images. For the
  releaser image, this avoids downloading the go sdk as part of the
  relase process.
- Add `build-container` make target for convenience.
- Update ci-operator build root to use rhel-9 golang 1.20 image for OCP
  4.15

Signed-off-by: Adam Kaplan <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 9, 2024

@adambkaplan: This pull request references BUILD-960 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

  • Update Dockerfiles to use the ubi9 go-toolset images. For the releaser image, this avoids downloading the go sdk as part of the relase process.
  • Add build-container make target for convenience.
  • Update ci-operator build root to use rhel-9 golang 1.20 image for OCP 4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from divyansh42 and jkhelil May 9, 2024 17:51
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
Copy link
Contributor

openshift-ci bot commented May 9, 2024

@adambkaplan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 349a4d9 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@adambkaplan
Copy link
Contributor Author

/assign @ayushsatyam146

We discussed building s2i with Konflux earlier today. I had previously started onboarding, but ran into an issue pulling the base images in this Dockerfile (which reference the OpenShift CI registry). This updates the Dockerfiles to use UBI images, which can be pulled from the Red Hat container catalog. The only limitation is creating a Red Hat account, which anyone can do using the Developer subscription.

@ayushsatyam146
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
Copy link
Contributor

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, ayushsatyam146

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bf52fc0 into openshift:master May 16, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants