Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Update Dockerfile with Immutable Tags #1192

Merged

Conversation

adambkaplan
Copy link
Contributor

Use Red Hat's immutable tags to ensure reproducible builds. This will also teach Renovate to only apply z-stream updates for ubi8/go-toolset, and y-stream updates for ubi8/ubi-minimal.

Use Red Hat's immutable tags to ensure reproducible builds. This will
also teach Renovate to only apply z-stream updates for ubi8/go-toolset,
and y-stream updates for ubi8/ubi-minimal.

Signed-off-by: Adam Kaplan <[email protected]>
@openshift-ci openshift-ci bot requested review from divyansh42 and jkhelil November 8, 2024 21:35
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2024
@adambkaplan adambkaplan changed the title Update Dockerfile with Immutable Tags NO-JIRA: Update Dockerfile with Immutable Tags Nov 8, 2024
@openshift-ci-robot
Copy link

@adambkaplan: This pull request explicitly references no jira issue.

In response to this:

Use Red Hat's immutable tags to ensure reproducible builds. This will also teach Renovate to only apply z-stream updates for ubi8/go-toolset, and y-stream updates for ubi8/ubi-minimal.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 8, 2024
Copy link
Contributor

openshift-ci bot commented Nov 8, 2024

@adambkaplan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security a1e6796 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sayan-biswas
Copy link
Contributor

/approved
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2024
Copy link
Contributor

openshift-ci bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, sayan-biswas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adambkaplan,sayan-biswas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9dc3cee into openshift:master Nov 11, 2024
6 of 7 checks passed
@adambkaplan adambkaplan deleted the reproducible-builds branch November 11, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants