Skip to content

Commit

Permalink
Revert 49a7fa to remove fake AWS creds
Browse files Browse the repository at this point in the history
I tested the changes @imjasonh made in adf030 without these fake aws
credentials and it does appear that the ten minutes slow down we were
observing in tektoncd#4087 are fixed.

This PR backs out the phony AWS creds that were in place on the
controller to work around long delays on initial image fetches for
entrypoint lookup (and bundles) related to k8schain.
  • Loading branch information
Scott authored and khrm committed May 19, 2022
1 parent 11b3dd6 commit a16e2e6
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions config/controller.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -93,17 +93,6 @@ spec:
valueFrom:
fieldRef:
fieldPath: metadata.namespace
# These phony AWS credentials are here to work around a bug in the aws go sdk
# that causes extremely long delays in the execution of tasks after the initial
# deployment of the Tekton Pipelines controller. See issue https://github.com/tektoncd/pipeline/issues/4087
# for more information.
- name: AWS_ACCESS_KEY_ID
value: foobarbaz
- name: AWS_SECRET_ACCESS_KEY
value: foobarbaz
- name: AWS_DEFAULT_REGION
value: foobarbaz

# If you are changing these names, you will also need to update
# the controller's Role in 200-role.yaml to include the new
# values in the "configmaps" "get" rule.
Expand Down

0 comments on commit a16e2e6

Please sign in to comment.