Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*:Update project with latest tools/dependencies #428

Closed
wants to merge 5 commits into from

Conversation

saswatamcode
Copy link
Member

@saswatamcode saswatamcode commented Aug 16, 2022

This PR updates several dependencies which were used by Telemeter to latest, and bumps the project to Go 1.17.

This also removes the tools dir, and replaces it with bingo.

Diff is large due to vendoring.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2022
@openshift-ci openshift-ci bot requested review from jan--f and philipgough August 16, 2022 03:10
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saswatamcode
Once this PR has been reviewed and has the lgtm label, please assign slashpai for approval by writing /assign @slashpai in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saswatamcode saswatamcode changed the title [WIP] *:Update project with latest tools/dependencies [WIP] *:Update project with latest docs/tools/dependencies Aug 16, 2022
@saswatamcode
Copy link
Member Author

/retest

@saswatamcode saswatamcode changed the title [WIP] *:Update project with latest docs/tools/dependencies *:Update project with latest docs/tools/dependencies Aug 23, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 23, 2022
@saswatamcode
Copy link
Member Author

saswatamcode commented Aug 23, 2022

I will follow up with another PR to convert the bash-based e2e tests to Go, not doing that here as diff would be really large. This PR is ready for review. 🙂

@saswatamcode saswatamcode changed the title *:Update project with latest docs/tools/dependencies *:Update project with latest tools/dependencies Aug 29, 2022
Signed-off-by: Saswata Mukherjee <[email protected]>
Signed-off-by: Saswata Mukherjee <[email protected]>
Signed-off-by: Saswata Mukherjee <[email protected]>
@saswatamcode
Copy link
Member Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 29, 2022

@saswatamcode: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration 06aa889 link true /test integration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 28, 2022
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2022
@openshift-merge-robot
Copy link
Contributor

@saswatamcode: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants