Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MON-3967: [bot] Bump openshift/thanos to v0.36.1 #149

Merged
merged 142 commits into from
Aug 13, 2024

Conversation

openshift-monitoring-bot[bot]
Copy link

Description

This is an automated version bump from CI.
The logs for this run can be found in the syncbot repo actions.
If you wish to perform this manually, execute the following commands from openshift/thanos repo:

git fetch https://github.com/thanos-io/thanos --tags
if ! git merge refs/tags/v0.36.0-rc.0 --no-edit; then
  git checkout --theirs CHANGELOG.md VERSION docs go.mod go.sum pkg tutorials .busybox-versions .devcontainer
  git checkout --ours 
  git add CHANGELOG.md VERSION docs go.mod go.sum pkg tutorials .busybox-versions .devcontainer 
  git merge --continue
fi
go mod tidy
go mod vendor

if [ -f scripts/rh-manifest.sh ]; then
  bash scripts/rh-manifest.sh
  git add rh-manifest.txt
  git diff --cached --exit-code || git commit -s -m "[bot] update rh-manifest.txt"
fi

kartikaysaxena and others added 30 commits April 29, 2024 11:13
This commit adds a resource_attributes field to the OTLP tracing configuration.

Signed-off-by: Filip Petkovski <[email protected]>
Signed-off-by: Filip Petkovski <[email protected]>
Allow specifying OTLP resource attributes for traces
For thanos-io#6775, it would be useful
to know the exact block IDs to aid debugging.

Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Saswata Mukherjee <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>
When using the exemplars proxy to search for exemplars on receivers, if one receiver had tenants that did not match the selector on the external label it would get
skipped completely even if it had a tenant that actually matched

Signed-off-by: Pedro Tanaka <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>
This commit adds a new tracing span for remotely delegated queries
with attributes related to the query and remote engine.

Signed-off-by: Filip Petkovski <[email protected]>
Signed-off-by: Filip Petkovski <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>
Adding a minimal test case for issue thanos-io#6775 - reproduces the panic in the
compactor.

Signed-off-by: Giedrius Statkevičius <[email protected]>
* Adding repro case for broken query with distributed engine

Signed-off-by: Pedro Tanaka <[email protected]>

* Fixing problem with distributed queries and xfunctios

Signed-off-by: Pedro Tanaka <[email protected]>

* Adding support for extended functions in tenancy enforcement

Signed-off-by: Pedro Tanaka <[email protected]>

* Moving custom parser to new package

Signed-off-by: Pedro Tanaka <[email protected]>

* fixing go-lint

Signed-off-by: Pedro Tanaka <[email protected]>

* Using same opts and reorganize imports

Signed-off-by: Pedro Tanaka <[email protected]>

* fixing problem with query format

Signed-off-by: Pedro Tanaka <[email protected]>

* fixing flaky tests

Signed-off-by: Pedro Tanaka <[email protected]>

* removing extra test

Signed-off-by: Pedro Tanaka <[email protected]>

* yet another flaky test

Signed-off-by: Pedro Tanaka <[email protected]>

---------

Signed-off-by: Pedro Tanaka <[email protected]>
Signed-off-by: Vanshikav123 <[email protected]>
* rule

Signed-off-by: Vanshikav123 <[email protected]>

* rule-changes

Signed-off-by: Vanshikav123 <[email protected]>

* prettier

Signed-off-by: Vanshikav123 <[email protected]>

* Rebuild

Signed-off-by: Vanshikav123 <[email protected]>

* changes after make react-app

Signed-off-by: Vanshikav123 <[email protected]>

---------

Signed-off-by: Vanshikav123 <[email protected]>
…ore-multitsdb

Query: fix exemplar proxying for receivers with multiple tenants
We have seen deadlocks with endpoint discovery caused by the metric
collector hanging and not releasing the store labels lock. This causes
the endpoint update to hang, which also makes all endpoint readers hang on
acquiring a read lock for the resolved endpoints slice.

This commit makes sure the Collect method on the metrics collector has
a built in timeout to guard against cases where an upstream call never
reads from the collection channel.

Signed-off-by: Filip Petkovski <[email protected]>
* Update minio-go to v7.0.70

Add support for EKS Pod Identity
fix issue: thanos-io#7157

Signed-off-by: farhad <[email protected]>

* Changelog - support for EKS Pod Identity

Updated changelog

Signed-off-by: farhad <[email protected]>

---------

Signed-off-by: farhad <[email protected]>
thanos-io#7338)

* fixing extended functions support in more places

Signed-off-by: Pedro Tanaka <[email protected]>

* Adding new failint for the Parse() method

Signed-off-by: Pedro Tanaka <[email protected]>

* Adding new method for ParseMetricSelector

Signed-off-by: Pedro Tanaka <[email protected]>

* Fixing missing imports

Extending test to check behavior

More missing imports

Signed-off-by: Pedro Tanaka <[email protected]>

* Fixing method name

Signed-off-by: Pedro Tanaka <[email protected]>

* Solving references to forbidden functions

Signed-off-by: Pedro Tanaka <[email protected]>

* Treating promql validation from ParseExpr

Signed-off-by: Pedro Tanaka <[email protected]>

* fixing funcs

Signed-off-by: Pedro Tanaka <[email protected]>

---------

Signed-off-by: Pedro Tanaka <[email protected]>
Signed-off-by: Pedro Tanaka <[email protected]>
Bumps [webpack](https://github.com/webpack/webpack) from 5.70.0 to 5.91.0.
- [Release notes](https://github.com/webpack/webpack/releases)
- [Commits](webpack/webpack@v5.70.0...v5.91.0)

---
updated-dependencies:
- dependency-name: webpack
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Filip Petkovski <[email protected]>
…arn/pkg/ui/react-app/webpack-5.91.0

Bump webpack from 5.70.0 to 5.91.0 in /pkg/ui/react-app
* Align tenant pruning according to wall clock.

Pruning a tenant currently acquires a lock on the tenant's TSDB,
which blocks reads from incoming queries. We have noticed spikes in
query latency when tenants get decomissioned since each receiver will
prune the tenant at a different time.

To reduce the window where queries get degraded, this commit makes sure that
pruning happens at predictable intervals by aligning it to the wall clock, similar
to how head compaction is aligned.

The commit also changes the tenant deletion condition to look at the duration
from the min time of the tenant, rather than from the last append time.

Signed-off-by: Filip Petkovski <[email protected]>

* Improve tests

Signed-off-by: Filip Petkovski <[email protected]>

---------

Signed-off-by: Filip Petkovski <[email protected]>
Bumps [ip](https://github.com/indutny/node-ip) from 1.1.5 to 1.1.9.
- [Commits](indutny/node-ip@v1.1.5...v1.1.9)

---
updated-dependencies:
- dependency-name: ip
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 1, 2024

@openshift-monitoring-bot[bot]: This pull request references MON-3967 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

Description

This is an automated version bump from CI.
The logs for this run can be found in the syncbot repo actions.
If you wish to perform this manually, execute the following commands from openshift/thanos repo:

git fetch https://github.com/thanos-io/thanos --tags
if ! git merge refs/tags/v0.36.0-rc.0 --no-edit; then
 git checkout --theirs CHANGELOG.md VERSION docs go.mod go.sum pkg tutorials .busybox-versions .devcontainer
 git checkout --ours 
 git add CHANGELOG.md VERSION docs go.mod go.sum pkg tutorials .busybox-versions .devcontainer 
 git merge --continue
fi
go mod tidy
go mod vendor

if [ -f scripts/rh-manifest.sh ]; then
 bash scripts/rh-manifest.sh
 git add rh-manifest.txt
 git diff --cached --exit-code || git commit -s -m "[bot] update rh-manifest.txt"
fi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2024
@simonpasquier
Copy link

/retest-required

@jan--f
Copy link

jan--f commented Aug 2, 2024

/approved
/retest-required

@simonpasquier
Copy link

/retest
/approve

Copy link

openshift-ci bot commented Aug 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-monitoring-bot[bot], simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 5b56736 and 2 for PR HEAD 7f589ca in total

@simonpasquier
Copy link

/retest-required

@simonpasquier
Copy link

/test e2e-agnostic-cmo

@simonpasquier
Copy link

/hold
the CI failures are probably valid.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2024
* Proxy: Query goroutine leak when `store.response-timeout` is set (thanos-io#7618)

time.AfterFunc() returns a time.Timer object whose C field is nil,
accroding to the documentation. A goroutine blocks forever on reading
from a `nil` channel, leading to a goroutine leak on random slow
queries.

Signed-off-by: Mikhail Nozdrachev <[email protected]>

* pkg/clientconfig: fix TLS configs with only CA (thanos-io#7634)

065e3dd introduced a regression: TLS configurations for Thanos Ruler
query and alerting with only a CA file failed to load.

For instance, the following snippet is a valid query configuration:

```
- static_configs:
  - prometheus.example.com:9090
  scheme: https
  http_config:
    tls_config:
      ca_file: /etc/ssl/cert.pem
```

The test fixtures (CA, certificate and key files) are copied from
prometheus/common and are valid until 2072.

Signed-off-by: Simon Pasquier <[email protected]>

* Cut patch release v0.36.1

Signed-off-by: Saswata Mukherjee <[email protected]>

* Fix failing e2e test (thanos-io#7620)

Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
Signed-off-by: Saswata Mukherjee <[email protected]>

---------

Signed-off-by: Mikhail Nozdrachev <[email protected]>
Signed-off-by: Simon Pasquier <[email protected]>
Signed-off-by: Saswata Mukherjee <[email protected]>
Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
Co-authored-by: Mikhail Nozdrachev <[email protected]>
Co-authored-by: Simon Pasquier <[email protected]>
Co-authored-by: Harry John <[email protected]>
@simonpasquier
Copy link

FYI we'll have to wait for v0.36.1 which will include thanos-io#7634.

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@monitoring-commit-bot monitoring-commit-bot bot force-pushed the automated-updates-master branch from 97bfd89 to 712ac2f Compare August 13, 2024 13:18
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2024
Copy link

openshift-ci bot commented Aug 13, 2024

New changes are detected. LGTM label has been removed.

@simonpasquier
Copy link

simonpasquier commented Aug 13, 2024

/retitle MON-3967: [bot] Bump openshift/thanos to v0.36.1

@openshift-ci openshift-ci bot changed the title MON-3967: [bot] Bump openshift/thanos to v0.36.0 MON-3967: [bot] Bump openshift/thanos to v0.36.1 Aug 13, 2024
@simonpasquier
Copy link

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2024
@simonpasquier
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2024
Copy link

openshift-ci bot commented Aug 13, 2024

@openshift-monitoring-bot[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1b29ca3 into openshift:master Aug 13, 2024
8 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: thanos
This PR has been included in build ose-thanos-container-v4.18.0-202408132015.p0.g1b29ca3.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.