OADP-1002: Ignore not found err for temp vsclass in cases of data mover without PVC #215
Conversation
| @@ -137,6 +138,12 @@ func DeleteTempVSClass(backupName string, tempVS snapshotv1listers.VolumeSnapsho | |||
| tempVSClassName := fmt.Sprintf("%s-snapclass", backupName) | |||
| tempVSClass, err := tempVS.Get(tempVSClassName) | |||
| if err != nil { | |||
| // ignore is not found err as it is possible to create data mover | |||
| @@ -137,6 +138,12 @@ func DeleteTempVSClass(backupName string, tempVS snapshotv1listers.VolumeSnapsho | |||
| tempVSClassName := fmt.Sprintf("%s-snapclass", backupName) | |||
There was a problem hiding this comment.
Maybe add a little comment about what the tempVSClass ? Not a dealbreaker.
There was a problem hiding this comment.
There's a small comment about temp vsclass in the backup controller
| // backup without an existing PVC | ||
| // in which case this VSClass will not exist | ||
| if apierrors.IsNotFound(err) { | ||
| return nil |
There was a problem hiding this comment.
seems fine to me IF the only errors we need to be concerned about are apierrors.
There was a problem hiding this comment.
AFAIK for this particular issue this should be the only error we're concerned about
|
/LGTM |
|
/cherry-pick konveyor-1.9.2 |
|
/cherry-pick oadp-1.1 |
|
@eemcmullan: new pull request created: #216 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@eemcmullan: new pull request created: #217 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.