Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ubi: BUILDPLATFORM to build stage to enable cross compile. #336

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

kaovilai
Copy link
Member

@kaovilai kaovilai commented Aug 12, 2024

Signed-off-by: Tiger Kaovilai [email protected]

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Speed up different arch builds
before adding BUILDPLATFORM

❯ docker system prune --all -f &&  time docker build -f Dockerfile.ubi . --platform=linux/amd64 
docker build -f Dockerfile.ubi . --platform=linux/amd64  1.89s user 3.26s system 2% cpu 3:21.93 total

after adding BUILDPLATFORM

❯ docker system prune --all -f &&  time docker build -f Dockerfile.ubi . --platform=linux/amd64 
docker build -f Dockerfile.ubi . --platform=linux/amd64  1.73s user 3.23s system 5% cpu 1:38.16 total
and I’m doing amd64 here cause my build system is arm.

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Copy link

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2024
mateusoliveira43

This comment was marked as resolved.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2024
Copy link

openshift-ci bot commented Aug 12, 2024

New changes are detected. LGTM label has been removed.

Copy link

openshift-ci bot commented Aug 12, 2024

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

@mateusoliveira43 mateusoliveira43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images job passed

@kaovilai kaovilai added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2024
Copy link

openshift-ci bot commented Aug 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: kaovilai, mateusoliveira43, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kaovilai kaovilai added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0e72752 into openshift:konveyor-dev Aug 12, 2024
3 checks passed
shubham-pampattiwar pushed a commit that referenced this pull request Aug 22, 2024
sseago pushed a commit to sseago/velero that referenced this pull request Sep 19, 2024
sseago pushed a commit to sseago/velero that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants