run oadp-operator e2e test from the velero repo

[weshayutin]

execute openshift/oadp-operator e2e tests directly against the velero repo locally or via prow ci

Thank you for contributing to Velero!

Please add a summary of your change

execute openshift/oadp-operator e2e tests directly against the velero repo locally or via prow ci

to test

optional: update the VELERO_IMAGE variable
execute: make -f Makefile.prow test-e2e

[weshayutin]

locally tested:

    Mongo application DATAMOVER
    /tmp/oadp-operator/tests/e2e/must-gather_suite_test.go:75
------------------------------
[AfterSuite] 
/tmp/oadp-operator/tests/e2e/e2e_suite_test.go:198
  > Enter [AfterSuite] TOP-LEVEL - /tmp/oadp-operator/tests/e2e/e2e_suite_test.go:198 @ 10/15/24 13:36:33.389
2024/10/15 13:36:33 Deleting Secrets
2024/10/15 13:36:33 Deleting DPA
  < Exit [AfterSuite] TOP-LEVEL - /tmp/oadp-operator/tests/e2e/e2e_suite_test.go:198 @ 10/15/24 13:36:33.595 (206ms)
[AfterSuite] PASSED [0.206 seconds]
------------------------------

Ran 1 of 33 Specs in 253.674 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 32 Skipped
PASS

[mateusoliveira43]

tested and idea is working (i.e. unsupported override is used in tests)

spec:
  backupLocations:
    - velero:
        config:
          profile: default
          region: ...
          s3ForcePathStyle: 'true'
          s3Url: '...'
        credential:
          key: cloud
          name: bsl-cloud-credentials-ibmcloud
        default: true
        objectStorage:
          bucket: ...
          prefix: velero-e2e-...
        provider: aws
  configuration:
    nodeAgent:
      enable: true
      podConfig:
        resourceAllocations: {}
      uploaderType: kopia
    velero:
      defaultPlugins:
        - openshift
        - aws
        - csi
      featureFlags:
        - EnableCSI
      logLevel: debug
  podDnsConfig: {}
  unsupportedOverrides:
    awsPluginImageFqin: ''
    azurePluginImageFqin: ''
    gcpPluginImageFqin: ''
    kubevirtPluginImageFqin: ''
    nonAdminControllerImageFqin: ''
    openshiftPluginImageFqin: ''
    resticRestoreImageFqin: ''
    veleroImageFqin: 'quay.io/konveyor/velero:latest'

But it still not clear to me how this will work in CI. Along CI image name, we also need OADP operator installed to run the tests

[kaovilai]

simplifies ENV used in Makefile

[kaovilai]

we also need OADP operator installed to run the tests

hopefully ocp/release repo test config can make it so operator is already installed, if not we can follow up later.

[weshayutin]

tested and idea is working (i.e. unsupported override is used in tests)

spec:
  backupLocations:
    - velero:
        config:
          profile: default
          region: ...
          s3ForcePathStyle: 'true'
          s3Url: '...'
        credential:
          key: cloud
          name: bsl-cloud-credentials-ibmcloud
        default: true
        objectStorage:
          bucket: ...
          prefix: velero-e2e-...
        provider: aws
  configuration:
    nodeAgent:
      enable: true
      podConfig:
        resourceAllocations: {}
      uploaderType: kopia
    velero:
      defaultPlugins:
        - openshift
        - aws
        - csi
      featureFlags:
        - EnableCSI
      logLevel: debug
  podDnsConfig: {}
  unsupportedOverrides:
    awsPluginImageFqin: ''
    azurePluginImageFqin: ''
    gcpPluginImageFqin: ''
    kubevirtPluginImageFqin: ''
    nonAdminControllerImageFqin: ''
    openshiftPluginImageFqin: ''
    resticRestoreImageFqin: ''
    veleroImageFqin: 'quay.io/konveyor/velero:latest'

But it still not clear to me how this will work in CI. Along CI image name, we also need OADP operator installed to run the tests

ya.. not sure if we'll do that via prow or via this makefile. If we DO need to do it via this makefile, wouldn't just a be a make deploy-olm from the oadp-operator dir? EASY no?

done1

[kaovilai]

make deploy-olm from the oadp-operator dir? EASY no?

deploy, and setup credentials stuff in prow so to not expose secrets in this makefile

[openshift-ci]

@weshayutin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[mpryc]

/lgtm

[mpryc]

/approve

[mpryc]

/gentle-ask-to-merge-this-pr Openshift CI, could you please kindly merge this PR as it has already been approved and has the lgtm label. Let's get this one through, shall we?

@kaovilai I think the following change (link below) broke velero CI as we don't have DOWNSTREAM_OWNERS file here?

openshift/release@cd8b87b#diff-a9035bbaee5af66130c81cfd0b97df589a7d2e22e87ad9d3800851407967c07bR695

The DOWNSTREAM_OWNERS should be in the konveyor-dev branch of this repository:
https://github.com/openshift/velero/blob/konveyor-dev/DOWNSTREAM_OWNERS

[kaovilai]

It's not broken from before. The change in release only allows us to add owners file without carrying conflicting changes with upstream owners. Upstream owners file may not be in the right format for prow or have our people on it anyways.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: kaovilai, mpryc, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kaovilai]

Demo of manual label override to continue auto merge