-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add style checks #28
Comments
Also for reference, google/android-fhir#290 (comment) |
The approach in the PR will use Spotless - similar to what Google has done. I think the main selling point is that you can add multiple linters to augment each other's strengths. One thing I don't like too much is that the linting process fails as part of the main Github Actions workflow that builds/compiles the code (I guess it's possible to break it off though). Another option is to use Codacy, similar to OpenSRP projects atm, which uses detekt as a linter - seems quite popular and under active development. Codacy UI is nicer and provides a separate enforceable code-quality check on Github. Either way, I think Spotless is good enough for now and provides a uniform set of rules as what we'd expect in the Android FHIR SDK. Since we'll be contributing to it, it would be better if we can have familiar workflows across both projects. |
Cool, yea agree w/that, there are be trade-offs but staying aligned forces our hand |
…p-sync-resources-with-custom-filters [Quest/Malawi Core] Android App : Sync Resources with custom filters
Consider ktfmt, https://github.com/facebookincubator/ktfmt
google/android-fhir#246
The text was updated successfully, but these errors were encountered: