Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style checks #28

Closed
pld opened this issue Mar 8, 2021 · 3 comments · Fixed by #70
Closed

Add style checks #28

pld opened this issue Mar 8, 2021 · 3 comments · Fixed by #70
Assignees

Comments

@pld
Copy link
Member

pld commented Mar 8, 2021

Consider ktfmt, https://github.com/facebookincubator/ktfmt

google/android-fhir#246

@pld
Copy link
Member Author

pld commented Mar 10, 2021

Also for reference, google/android-fhir#290 (comment)

@vincent-karuri
Copy link
Contributor

The approach in the PR will use Spotless - similar to what Google has done. I think the main selling point is that you can add multiple linters to augment each other's strengths.

One thing I don't like too much is that the linting process fails as part of the main Github Actions workflow that builds/compiles the code (I guess it's possible to break it off though).

Another option is to use Codacy, similar to OpenSRP projects atm, which uses detekt as a linter - seems quite popular and under active development. Codacy UI is nicer and provides a separate enforceable code-quality check on Github.

Either way, I think Spotless is good enough for now and provides a uniform set of rules as what we'd expect in the Android FHIR SDK. Since we'll be contributing to it, it would be better if we can have familiar workflows across both projects.

@pld
Copy link
Member Author

pld commented Apr 7, 2021

Cool, yea agree w/that, there are be trade-offs but staying aligned forces our hand

@pld pld closed this as completed in #70 Apr 7, 2021
LZRS pushed a commit that referenced this issue Feb 29, 2024
…p-sync-resources-with-custom-filters

[Quest/Malawi Core] Android App : Sync Resources with custom filters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants