Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config Composition section to support custom search parameters #3695

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

LZRS
Copy link
Contributor

@LZRS LZRS commented Jan 21, 2025

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3532

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@LZRS LZRS self-assigned this Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 18.27957% with 76 lines in your changes missing coverage. Please review.

Project coverage is 38.7%. Comparing base (e501d27) to head (cc88213).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...tion/customsearch/SearchParametersConfigService.kt 0.0% 49 Missing ⚠️
...smartregister/fhircore/engine/FhirEngineWrapper.kt 0.0% 18 Missing ⚠️
...ne/util/extension/CompositionResourceExtensions.kt 60.0% 6 Missing and 2 partials ⚠️
...ircore/engine/util/extension/ReferenceExtension.kt 50.0% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (18.2%) is below the target coverage (60.0%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3695     +/-   ##
=========================================
- Coverage     39.1%   38.7%   -0.4%     
+ Complexity    1167    1166      -1     
=========================================
  Files          284     287      +3     
  Lines        15090   15091      +1     
  Branches      2671    2669      -2     
=========================================
- Hits          5904    5851     -53     
- Misses        8341    8398     +57     
+ Partials       845     842      -3     
Flag Coverage Δ
engine 61.9% <18.2%> (-1.1%) ⬇️
geowidget 16.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...core/engine/configuration/ConfigurationRegistry.kt 72.0% <100.0%> (+<0.1%) ⬆️
...hircore/engine/util/extension/ResourceExtension.kt 67.1% <ø> (-0.4%) ⬇️
...hircore/quest/ui/appsetting/AppSettingViewModel.kt 60.0% <ø> (-3.2%) ⬇️
...ircore/engine/util/extension/ReferenceExtension.kt 57.1% <50.0%> (-14.3%) ⬇️
...ne/util/extension/CompositionResourceExtensions.kt 60.0% <60.0%> (ø)
...smartregister/fhircore/engine/FhirEngineWrapper.kt 0.0% <0.0%> (ø)
...tion/customsearch/SearchParametersConfigService.kt 0.0% <0.0%> (ø)

... and 3 files with indirect coverage changes

@LZRS LZRS force-pushed the 3532-custom-search-param branch from 1db3ecb to 292dc8b Compare January 22, 2025 00:08
@LZRS LZRS force-pushed the 3532-custom-search-param branch from 292dc8b to 50ccdce Compare January 22, 2025 22:38
@LZRS LZRS requested review from ellykits and Rkareko January 27, 2025 07:02
@LZRS LZRS marked this pull request as ready for review January 27, 2025 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance the process of adding custom search parameters to be configurable
1 participant