Remove ctlplane_vip from undercloud control plane bridge

[ciecierski]

No description provided.

[github-actions]

Thanks for the PR! ❤️
I'm marking it as a draft, once your happy with it merging and the PR is passing CI, click the "Ready for review" button below.

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8fa369cf49ad45428bd9d5d15e1a5623

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 35m 07s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 12m 58s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 13m 41s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 45s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 49s
✔️ build-push-container-cifmw-client SUCCESS in 37m 45s

[ciecierski]

recheck

[frenzyfriday]

I do not have the context behind why ctlplane_vip is removed but lgtm as per the commit msg + sanity check (it is not being used anywhere else)
/lgtm

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from frenzyfriday. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from frenzyfriday. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ac480681042f42a59314ed60fffe3817

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 51m 10s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 27m 12s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 37m 38s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 31s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 51s
✔️ build-push-container-cifmw-client SUCCESS in 17m 11s

[hjensas]

I do not agree with this change. The undercloud should have two VIPs.
The issue here is conflicting addresses used in openstack-k8s-operators/data-plane-adoption HCI scenarion.

[1] Is the undercloud's VIP on the ctlplane network.
[2] Is the overcloud's VIP on the ctlplane network.

These addresses cannot be the same, the undercloud VIP is hosted on the undercloud node. The overcloud VIP is controlled by pacemaker cluster on the overcloud nodes.

In the uni01alpha scenario in data-plane-adoption you will see that undercloud ctlplane VIP is 192.168.122.101 and overcloud VIP is 192.168.122.99 - to avoid the overlap.

The VIP's on the undercloud is controller by undercloud.conf options:
undercloud_public_host, undercloud_admin_host. Looking at [3] it seems these are set to nthhost(122) and nthhost(123) - which does not match what we define as VIP in data-plane-adoption scenario.

[1] https://github.com/openstack-k8s-operators/data-plane-adoption/blob/main/scenarios/hci.yaml#L24
[2] https://github.com/openstack-k8s-operators/data-plane-adoption/blob/main/scenarios/hci/vips_data.yaml#L20
[3] https://github.com/openstack-k8s-operators/ci-framework/blob/6295c4e3f419db89bbccef61eddebecfaaf37161/roles/adoption_osp_deploy/tasks/prepare_undercloud.yml#L137C1-L142C69