Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to structured logging #86

Conversation

pinikomarov
Copy link
Contributor

@pinikomarov pinikomarov commented Sep 3, 2023

This automatically adds additional fields like reconcile_id etc.. from the controller context.

before :

2023-05-18T01:53:14+03:00 INFO controllers.KeystoneAPI Reconciled Service init successfully

after:

2023-05-18T02:00:28+03:00 INFO Controllers.KeystoneAPI Reconciled Service init successfully {"controller": "keystoneapi", "controllerGroup": "keystone.openstack.org", "controllerKind":"KeystoneAPI", "KeystoneAPI": {"name":"keystone","namespace":"openstack"}, "namespace": "openstack", "name": "keystone", "reconcileID": "512a4d9b-f31d-4fa4-a4cc-cd6c13e4455d"}

*by using per reconcile function respective logger objects, the intention is to lay the ground for parallel reconciliation in future and avoid race conditions as ctx objects are reconcile run specific.

*example logs lines are currently from keystone operator #220_patch until this operator deployment patch testing is is done

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 3, 2023

Hi @pinikomarov. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pinikomarov pinikomarov marked this pull request as ready for review October 15, 2023 09:56
@openshift-ci openshift-ci bot requested review from abays and viroel October 15, 2023 09:56
@pinikomarov pinikomarov force-pushed the structured_logging branch 2 times, most recently from f1db306 to 8c435d4 Compare October 19, 2023 09:58
@pinikomarov
Copy link
Contributor Author

code doesn't have any obvious errors , but testing this patch with an applied cr is not working out of the box :

[crc@titan88 designate-operator]$  oc apply -f config/samples/designate_v1beta1_designate.yaml        
error: resource mapping not found for name: "designate" namespace: "openstack" from "config/samples/designate_v1beta1_designate.yaml": no matches for kind "Designate" in version "designate.openstack.org/v1beta1"
ensure CRDs are installed first

@pinikomarov pinikomarov force-pushed the structured_logging branch 2 times, most recently from 49d92a7 to 08cacc3 Compare October 28, 2023 01:44
@pinikomarov pinikomarov force-pushed the structured_logging branch 2 times, most recently from 304a331 to 06d05b5 Compare November 7, 2023 14:13
@abays
Copy link
Contributor

abays commented Nov 16, 2023

/ok-to-test

update logging

update logging

update logging

update logging

update logging

update logging fixup lint

Structured logging
@beagles
Copy link
Collaborator

beagles commented Nov 30, 2023

/lgtm

@pinikomarov
Copy link
Contributor Author

@beagles does this need an "/approved label" ?

Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, pinikomarov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 5, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit b5000fa into openstack-k8s-operators:main Dec 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants