Allow passing extra args to kubectl-kuttl #1012
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karelyatin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Makefile
Outdated
| @@ -2030,7 +2030,7 @@ openstack_kuttl_run: ## runs kuttl tests for the openstack operator, assumes tha | |||
| oc delete osctlplane --all --namespace ${NAMESPACE}; \ | |||
| make crc_storage_cleanup_with_retries; \ | |||
| make crc_storage_with_retries; \ | |||
| kubectl-kuttl test --config ${OPENSTACK_KUTTL_CONF} ${OPENSTACK_KUTTL_DIR} --test $${test_dir}; \ | |||
| kubectl-kuttl test --config ${OPENSTACK_KUTTL_CONF} ${OPENSTACK_KUTTL_DIR} --test $${test_dir}; \ $(KUTTL_ARGS) | |||
There was a problem hiding this comment.
${KUTTL_ARGS} is coming after a semi-colon on this line.
There was a problem hiding this comment.
good catch, i just did sed at all places :)
There was a problem hiding this comment.
Not adding at all to this target as already using --test arg in it.
There was a problem hiding this comment.
@bshephar can you check again
Can now pass arbitary args while running test, for example to run a specific test can run:- make ovn_kuttl_run KUTTL_ARGS="--test ovn-config"
karelyatin
force-pushed
the
kuttl_args
branch
from
5e3dc1d to
7cbedc2
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e339fda146f54ff4b5e017c8b74f01ee ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 11m 11s |
|
recheck RETRY_LIMIT |
Can now pass arbitary args while running test, for example to run a specific test can run:-
make ovn_kuttl_run KUTTL_ARGS="--test ovn-config"