Add noindex attribute to document element #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supports values 'true' and 'false'
philschatz
approved these changes
Jun 27, 2024
| <attribute name="noindex"> | ||
| <choice> | ||
| <value>true</value> | ||
| <value>false</value> |
There was a problem hiding this comment.
Do we denote 2 ways to describe "false" in other places? I don't remember, just hoping to keep things consistent. Also, if the only possible value is "true" then autocomplete might be faster.
There was a problem hiding this comment.
There are many other attributes that are defined this way. I think removing false as an option is a good idea. POET is already using this definition on the main branch, so I will merge this PR and then remove false in a different PR to try to keep things consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of openstax/ce#2240
Supports values 'true' and 'false'