Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the homepage #399

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Modified the homepage #399

wants to merge 4 commits into from

Conversation

Coder-Srinivas
Copy link
Contributor

No description provided.

Copy link
Collaborator

@chrisbendel chrisbendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great - i can try to get this deployed to staging for iris's testing and approval!

window.KINETIC.postScriptRan = true;
}
};
document.addEventListener('DOMContentLoaded', () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason we can't just use the href attribute on these links wherever they're defined in html?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it in javascript to make it uniform. I'll add the href tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants