Merge pull request #214 from openstax/fixts

adding element focuse and assertion

.github/workflows/tests.yml

@@ -35,7 +35,7 @@ jobs:
           sed -Ei 's/("version": ")(.+)(",)$/\1\2-'$VERSION_VALUE'\3/' package.json
           npm run build:production
       - name: Upload Extension
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: editor-extension
           path: editor-*.vsix

tests/ui/pages/home.py

@@ -79,10 +79,6 @@ def push_message_input_field_is_visible(self):
     def push_message_input_field_not_visible(self):
         return self.page.locator("div.monaco-inputbox.idle")
 
-    @property
-    def push_content_dialog_box(self):
-        return self.page.locator("div > div.notifications-toasts.visible")
-
     @property
     def generate_readme_button_is_visible(self):
         return self.page.get_by_text("Generate README", exact=True)
@@ -279,6 +275,7 @@ def gitpod_menubar_locator(self):
         return self.page.locator("div.menubar-menu-button")
 
     def click_gitpod_menubar(self):
+        self.gitpod_menubar_locator.focus()
         self.gitpod_menubar_locator.click()
 
     @property

tests/ui/test_readme_validate_other_features.py

@@ -48,7 +48,6 @@ def test_readme_validate_other_features(
     home.click_push_content_button()
 
     assert home.push_message_input_field_is_visible
-    assert "Push Content: Pushing..." in home.push_content_dialog_box.inner_text()
 
     chrome_page.keyboard.press("Escape")
     assert home.push_message_input_field_not_visible