🎨 update GitHub actions and node version (#188)

* update GitHub actions and node version * update package versions and fix jest ```sh npm install -g npm-check-updates ncu -u npm run test:unit --updateSnapshot ``` * update cypress * 👕 lint * 🔥 unused comment * 🐛 fix cypress coverage
openstax · Dec 16, 2023 · d4f55c4 · d4f55c4
1 parent bc449da
commit d4f55c4
Show file tree

Hide file tree

Showing 72 changed files with 8,580 additions and 11,441 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -0,0 +1,3 @@
+/cypress.config.ts
+/client/src/webview-js/cnxml-preview/cnxml-preview.js
+/client/src/webview-js/toc-editor/toc-editor.jsx
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -12,12 +12,12 @@ jobs:
     timeout-minutes: 30
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 2
-      - uses: actions/setup-node@v2
+      - uses: actions/setup-node@v4
         with:
-          node-version: '14'
+          node-version: '18'
       - name: Setup
         run: |
           npm install
@@ -43,7 +43,7 @@ jobs:
         run: |
           xvfb-run -a npm run test
       - name: Upload Code Coverage
-        uses: codecov/codecov-action@v2
+        uses: codecov/codecov-action@v3
       - name: Lint
         run: |
           npm run lint
diff --git a/client/specs/__snapshots__/book-tocs.spec.ts.snap b/client/specs/__snapshots__/book-tocs.spec.ts.snap
@@ -1,11 +1,11 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
 exports[`Toc Provider filters fileids when filtering is set 1`] = `
-Object {
+{
   "collapsibleState": "None",
-  "command": Object {
-    "arguments": Array [
-      Object {
+  "command": {
+    "arguments": [
+      {
         "$mid": 1,
         "path": "/path/to/file",
         "scheme": "file",
@@ -17,7 +17,7 @@ Object {
   "description": "fileId",
   "iconPath": "File",
   "label": "title",
-  "resourceUri": Object {
+  "resourceUri": {
     "$mid": 1,
     "path": "/path/to/file",
     "scheme": "file",
@@ -26,11 +26,11 @@ Object {
 `;
 
 exports[`Toc Provider filters fileids when filtering is set 2`] = `
-Object {
+{
   "collapsibleState": "None",
-  "command": Object {
-    "arguments": Array [
-      Object {
+  "command": {
+    "arguments": [
+      {
         "$mid": 1,
         "path": "/path/to/file",
         "scheme": "file",
@@ -41,7 +41,7 @@ Object {
   },
   "iconPath": "File",
   "label": "title (fileId)",
-  "resourceUri": Object {
+  "resourceUri": {
     "$mid": 1,
     "path": "/path/to/file",
     "scheme": "file",
@@ -50,11 +50,11 @@ Object {
 `;
 
 exports[`Toc Provider filters fileids when filtering is set 3`] = `
-Object {
+{
   "collapsibleState": "None",
-  "command": Object {
-    "arguments": Array [
-      Object {
+  "command": {
+    "arguments": [
+      {
         "$mid": 1,
         "path": "/path/to/file",
         "scheme": "file",
@@ -66,7 +66,7 @@ Object {
   "description": "fileId",
   "iconPath": "File",
   "label": "title",
-  "resourceUri": Object {
+  "resourceUri": {
     "$mid": 1,
     "path": "/path/to/file",
     "scheme": "file",
@@ -75,11 +75,11 @@ Object {
 `;
 
 exports[`Toc Provider returns tree items for children 1`] = `
-Object {
+{
   "collapsibleState": "Collapsed",
-  "command": Object {
-    "arguments": Array [
-      Object {
+  "command": {
+    "arguments": [
+      {
         "$mid": 1,
         "path": "/some/path",
         "scheme": "file",
@@ -91,7 +91,7 @@ Object {
   "description": "slug",
   "iconPath": ThemeIcon {},
   "label": "title",
-  "resourceUri": Object {
+  "resourceUri": {
     "$mid": 1,
     "path": "/some/path",
     "scheme": "file",
@@ -100,19 +100,19 @@ Object {
 `;
 
 exports[`Toc Provider returns tree items for children 2`] = `
-Object {
+{
   "collapsibleState": "Collapsed",
   "iconPath": "Folder",
   "label": "title",
 }
 `;
 
 exports[`Toc Provider returns tree items for children 3`] = `
-Object {
+{
   "collapsibleState": "None",
-  "command": Object {
-    "arguments": Array [
-      Object {
+  "command": {
+    "arguments": [
+      {
         "$mid": 1,
         "path": "/path/to/file",
         "scheme": "file",
@@ -124,7 +124,7 @@ Object {
   "description": "fileId",
   "iconPath": "File",
   "label": "title",
-  "resourceUri": Object {
+  "resourceUri": {
     "$mid": 1,
     "path": "/path/to/file",
     "scheme": "file",

diff --git a/client/specs/__snapshots__/cnxml-preview.spec.ts.snap b/client/specs/__snapshots__/cnxml-preview.spec.ts.snap
@@ -2,7 +2,7 @@
 
 exports[`cnxml-preview simple tagElementsWithLineNumbers 1`] = `
 "
-      <document data-line=\\"2\\">
-          <div data-line=\\"3\\"><span data-line=\\"3\\">Test</span><div data-line=\\"3\\"/></div>
+      <document data-line="2">
+          <div data-line="3"><span data-line="3">Test</span><div data-line="3"/></div>
       </document>"
 `;