as per review, removed pass statements

openstax · Dec 11, 2023 · e3a88d8 · e3a88d8
1 parent 4fda2fd
commit e3a88d8
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 24 deletions.
diff --git a/tests/ui/test_home_ui.py b/tests/ui/test_home_ui.py
@@ -14,21 +14,16 @@ def test_home_ui(chrome_page, github_user, github_password, gitpod_repo_url):
     chrome_page.goto(gitpod_repo_url)
     home = HomePoet(chrome_page)
 
-    if not home.continue_with_github_is_visible:
-        pass
-
-    home.click_continue_with_github_button()
+    if home.continue_with_github_is_visible:
+        home.click_continue_with_github_button()
 
     with chrome_page.context.pages[1] as github_login_window:
         github_login_window.fill("#login_field", github_user)
         github_login_window.fill("#password", github_password)
 
         github_login_window.click(sign_in_button_selector)
 
-    if home.gitpod_user_dropdown.inner_text() == "0 openstax":
-        pass
-
-    else:
+    if home.gitpod_user_dropdown.inner_text() != "0 openstax":
         home.click_gitpod_user_dropdown()
         home.click_gitpod_user_selector()
 

diff --git a/tests/ui/test_readme_validate_other_features.py b/tests/ui/test_readme_validate_other_features.py
@@ -16,21 +16,16 @@ def test_readme_validate_other_features(
     chrome_page.goto(gitpod_repo_url)
     home = HomePoet(chrome_page)
 
-    if not home.continue_with_github_is_visible:
-        pass
-
-    home.click_continue_with_github_button()
+    if home.continue_with_github_is_visible:
+        home.click_continue_with_github_button()
 
     with chrome_page.context.pages[1] as github_login_window:
         github_login_window.fill("#login_field", github_user)
         github_login_window.fill("#password", github_password)
 
         github_login_window.click(sign_in_button_selector)
 
-    if home.gitpod_user_dropdown.inner_text() == "0 openstax":
-        pass
-
-    else:
+    if home.gitpod_user_dropdown.inner_text() != "0 openstax":
         home.click_gitpod_user_dropdown()
         home.click_gitpod_user_selector()
 

diff --git a/tests/ui/test_toc_editor.py b/tests/ui/test_toc_editor.py
@@ -15,21 +15,16 @@ def test_toc_editor(chrome_page, github_user, github_password, gitpod_repo_url):
     home = HomePoet(chrome_page)
 
     # WHEN: login into openstax/osbooks-otto-book repo
-    if not home.continue_with_github_is_visible:
-        pass
-
-    home.click_continue_with_github_button()
+    if home.continue_with_github_is_visible:
+        home.click_continue_with_github_button()
 
     with chrome_page.context.pages[1] as github_login_window:
         github_login_window.fill("#login_field", github_user)
         github_login_window.fill("#password", github_password)
 
         github_login_window.click(sign_in_button_selector)
 
-    if home.gitpod_user_dropdown.inner_text() == "0 openstax":
-        pass
-
-    else:
+    if home.gitpod_user_dropdown.inner_text() != "0 openstax":
         home.click_gitpod_user_dropdown()
         home.click_gitpod_user_selector()