Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix dangling comment node #185

Merged
merged 2 commits into from
Dec 1, 2023
Merged

🐛 fix dangling comment node #185

merged 2 commits into from
Dec 1, 2023

Conversation

philschatz
Copy link
Member

This was causing the preview to fail when a comment occurred after the root <document> element.

refs https://github.com/openstax/ce/issues/2129

@philschatz philschatz requested a review from a team November 14, 2023 21:44
TylerZeroMaster
TylerZeroMaster approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@TylerZeroMaster TylerZeroMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If I understand correctly, comments were being parsed as document fragments when they were at the root level. Since comments are not handled, they became null and created the issue.

@therealmarv therealmarv self-requested a review November 16, 2023 16:12
@philschatz philschatz merged commit eb1e67e into main Dec 1, 2023
3 checks passed
@philschatz philschatz deleted the fix-preview branch December 1, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerZeroMaster TylerZeroMaster TylerZeroMaster approved these changes

@therealmarv therealmarv therealmarv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philschatz @therealmarv @TylerZeroMaster