Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2209 h5p exercise url #194

Merged
merged 7 commits into from
May 9, 2024
Merged

2209 h5p exercise url #194

merged 7 commits into from
May 9, 2024

Conversation

TylerZeroMaster
Copy link
Contributor

fixes openstax/ce#2209

Summary

  • Add H5P exercise type (not part of resources because of the number of assumptions made about resources).
  • Add note about paths being hardcoded into file system watchers and likelihood of watcher system changing.
  • Check H5P exercise exists as part of page validation.
  • Add H5P exercise url autocompletion.

Known issues

While making these changes, I found a few problems and I am working on making new issues for each since they are outside of the scope of 2209.

  • Directory creation events are not handled at all. Moving a directory containing content that POET understands into an area POET is watching does not result in that content being added to the bundle.
  • Page validation errors related to content not existing, i.e. resource or h5p, do not update until the page updates.
  • Content paths are hardcoded into client where file system watchers are created.

@TylerZeroMaster TylerZeroMaster requested a review from a team May 1, 2024 14:50
Copy link
Member

@philschatz philschatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TylerZeroMaster TylerZeroMaster merged commit f5de166 into main May 9, 2024
1 check passed
@TylerZeroMaster TylerZeroMaster deleted the 2209-h5p-exercise-url branch May 9, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants