Make md:title optional in patch file #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's already optional in the unpatched schema
|
(writing test cases on the PR instead of this issue this time because the issue has more criteria) md:title should now be optionalGIVEN
WHEN
THEN
Document title should still be requiredGIVEN
WHEN
THEN
|
|
verified in editor-0.0.0-dev-199.vsix corgi job (without md:title) - fails (another PR fixes this) - waiting for the next corgi deploy! |
|
verified in poet ext 7.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of openstax/ce#1528
It's already optional in the unpatched schema.