Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema with new 'noindex' document attribute #200

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

TylerZeroMaster
Copy link
Contributor

part of openstax/ce#2240

Update schema to allow noindex attribute on document

@TylerZeroMaster TylerZeroMaster requested a review from a team June 17, 2024 21:18
@TylerZeroMaster TylerZeroMaster self-assigned this Jun 17, 2024
Copy link
Contributor

@sparksam sparksam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@TylerZeroMaster TylerZeroMaster force-pushed the 2240-update-schema-support-noindex branch from 2930b58 to d40c646 Compare June 24, 2024 19:01
@TylerZeroMaster TylerZeroMaster merged commit 7244d86 into main Jun 24, 2024
1 check passed
@TylerZeroMaster TylerZeroMaster deleted the 2240-update-schema-support-noindex branch June 24, 2024 19:07
@TylerZeroMaster
Copy link
Contributor Author

TylerZeroMaster commented Jun 24, 2024

noindex attribute is optional

GIVEN

WHEN

  • A document element does not have a noindex attribute

THEN

  • There are no validation errors

noindex attribute only supports values true and false

GIVEN

WHEN

  • The noindex attribute is added to the document element in a module
  • The value of the attribute is set to anything other than "true" or "false" (Known issue: whitespace is ignored during validation so values like "true " will also be valid)

THEN

  • There are no validation errors related to xml schema

noindex attribute is only supported on document element

GIVEN

WHEN

  • The noindex attribute is added to anything other than a document element with a value of "true" or "false"

THEN

  • There are validation errors related to xml schema

@omehes
Copy link
Contributor

omehes commented Jun 24, 2024

all tests passed. looks good with the dev extension provided

@omehes
Copy link
Contributor

omehes commented Jul 17, 2024

verified in poet ext. 7.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants