More validation for assumptions made in Enki #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Epub builds assume books will be named <slug>.collection.xml
Match ranges to target specific book node for validation
TylerZeroMaster
force-pushed
the
booksxml-slug-validation
branch
from
2f209d2 to
7b3aed4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Book slugs are defined in three places--books.xml, collection file name, collection file metadata--and must match in all three places. This is a common source of build errors in newly created books. Most processes in Enki use the slug from the books.xml file, however, there are a few exceptions.
Codify the assumptions made about book slugs.