Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to mathml3 #207

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Upgrade to mathml3 #207

merged 4 commits into from
Jul 16, 2024

Conversation

TylerZeroMaster
Copy link
Contributor

@TylerZeroMaster TylerZeroMaster commented Jul 1, 2024

see openstax/ce#1584 if you would like additional background information
related to openstax/ce#1909
related to openstax/cnxml#65

Unfortunately a patch is required to add the correct math elements to two definitions of semantics.

philschatz and others added 3 commits July 1, 2024 14:02
This time I used a newer version of jing and trang.

There are some new groups

Reading about these, it seems like they are a catch-all used to make validation ignore unrecognized elements

The annotation-xml mathml element supports html which likely explains why these are added
@TylerZeroMaster TylerZeroMaster requested a review from a team July 1, 2024 20:36
@TylerZeroMaster TylerZeroMaster self-assigned this Jul 1, 2024
Copy link
Contributor

@sparksam sparksam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@TylerZeroMaster TylerZeroMaster merged commit b8abe80 into main Jul 16, 2024
1 check passed
@TylerZeroMaster TylerZeroMaster deleted the mathml3-schema-patched branch July 16, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants