Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding element focuse and assertion #214

Merged
merged 2 commits into from
Sep 25, 2024
Merged

adding element focuse and assertion #214

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3c8945
changes to focusing and more
omehes Sep 25, 2024
7cd0881
Use upload-artifact version 4
TylerZeroMaster Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions tests/ui/pages/home.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,6 @@ def push_message_input_field_is_visible(self):
def push_message_input_field_not_visible(self):
return self.page.locator("div.monaco-inputbox.idle")

@property
def push_content_dialog_box(self):
return self.page.locator("div > div.notifications-toasts.visible")

@property
def generate_readme_button_is_visible(self):
return self.page.get_by_text("Generate README", exact=True)
Expand Down Expand Up @@ -279,6 +275,7 @@ def gitpod_menubar_locator(self):
return self.page.locator("div.menubar-menu-button")

def click_gitpod_menubar(self):
self.gitpod_menubar_locator.focus()
self.gitpod_menubar_locator.click()

@property
Expand Down
1 change: 0 additions & 1 deletion tests/ui/test_readme_validate_other_features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ def test_readme_validate_other_features(
home.click_push_content_button()

assert home.push_message_input_field_is_visible
assert "Push Content: Pushing..." in home.push_content_dialog_box.inner_text()

chrome_page.keyboard.press("Escape")
assert home.push_message_input_field_not_visible
Expand Down
Loading